Add Batch logging

Add Batch logging

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ca1f07eb5f976a39845721b434b780c5a705f3d9

[joshualitt, 2015-08-06 16:08:44]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-08-06 16:08:44]

ptal

[bsalomon, 2015-08-06 17:54:12]

https://codereview.chromium.org/1276913002/diff/20001/src/gpu/GrBatch.h
File src/gpu/GrBatch.h (right):

https://codereview.chromium.org/1276913002/diff/20001/src/gpu/GrBatch.h#newco...
src/gpu/GrBatch.h:39: #define BATCH_SPEW
Since it's in a header, maybe GR_BATCH_SPEW?

Also we usually define macros to 0 to disable or 1 to enable. It allows you type
compound checks that are a mix of runtime and compile time without a lot if
#idef/#else:

if (GR_BATCH_SPEW && this->isAmazing()) {
   this->printSomeCoolStuff();
}

[joshualitt, 2015-08-07 14:42:36]

On 2015/08/06 17:54:12, bsalomon wrote:
> https://codereview.chromium.org/1276913002/diff/20001/src/gpu/GrBatch.h
> File src/gpu/GrBatch.h (right):
> 
>
https://codereview.chromium.org/1276913002/diff/20001/src/gpu/GrBatch.h#newco...
> src/gpu/GrBatch.h:39: #define BATCH_SPEW
> Since it's in a header, maybe GR_BATCH_SPEW?
> 
> Also we usually define macros to 0 to disable or 1 to enable. It allows you
type
> compound checks that are a mix of runtime and compile time without a lot if
> #idef/#else:
> 
> if (GR_BATCH_SPEW && this->isAmazing()) {
>    this->printSomeCoolStuff();
> }

I added more

[bsalomon, 2015-08-07 15:00:37]

lgtm

[bsalomon, 2015-08-07 15:00:38]

lgtm

[joshualitt, 2015-08-07 15:00:47]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-08-07 15:00:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1276913002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1276913002/180001

[commit-bot: I haz the power, 2015-08-07 15:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-07 15:01:29]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[joshualitt, 2015-08-07 15:03:45]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-08-07 15:03:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1276913002/#ps200001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-07 15:03:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1276913002/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1276913002/200001

[commit-bot: I haz the power, 2015-08-07 15:11:22]

Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/ca1f07eb5f976a39845721b434b780c5a705f3d9