Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: src/gpu/GrReorderCommandBuilder.cpp

Issue 1276913002: Add Batch logging (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/GrInOrderCommandBuilder.cpp ('k') | src/gpu/GrTargetCommands.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/GrReorderCommandBuilder.cpp
diff --git a/src/gpu/GrReorderCommandBuilder.cpp b/src/gpu/GrReorderCommandBuilder.cpp
index 90953b047b00b2bf33757e97f70d9b6824ffcb23..c7b5f97da4949e6af9bc9157f837845ea3e0a33d 100644
--- a/src/gpu/GrReorderCommandBuilder.cpp
+++ b/src/gpu/GrReorderCommandBuilder.cpp
@@ -25,6 +25,26 @@ GrTargetCommands::Cmd* GrReorderCommandBuilder::recordDrawBatch(State* state, Gr
int i = 0;
batch->setPipeline(state->getPipeline());
GrRenderTarget* rt = state->getPipeline()->getRenderTarget();
+
+ GrBATCH_INFO("Re-Recording (%s, B%u)\n"
+ "\tRenderTarget %p\n"
+ "\tBounds (%f, %f, %f, %f)\n",
+ batch->name(),
+ batch->uniqueID(), rt,
+ batch->bounds().fLeft, batch->bounds().fRight,
+ batch->bounds().fTop, batch->bounds().fBottom);
+#if GR_BATCH_SPEW
+ SkDebugf("\tColorStages:\n");
+ for (int i = 0; i < state->getPipeline()->numColorFragmentStages(); i++) {
+ SkDebugf("\t\t%s\n", state->getPipeline()->getColorStage(i).processor()->name());
+ }
+ SkDebugf("\tCoverageStages:\n");
+ for (int i = 0; i < state->getPipeline()->numCoverageFragmentStages(); i++) {
+ SkDebugf("\t\t%s\n", state->getPipeline()->getCoverageStage(i).processor()->name());
+ }
+ SkDebugf("\tXP: %s\n", state->getPipeline()->getXferProcessor()->name());
+#endif
+ GrBATCH_INFO("\tOutcome:\n");
if (!this->cmdBuffer()->empty()) {
GrTargetCommands::CmdBuffer::ReverseIter reverseIter(*this->cmdBuffer());
@@ -33,14 +53,20 @@ GrTargetCommands::Cmd* GrReorderCommandBuilder::recordDrawBatch(State* state, Gr
DrawBatch* previous = static_cast<DrawBatch*>(reverseIter.get());
if (previous->fBatch->pipeline()->getRenderTarget() != rt) {
+ GrBATCH_INFO("\t\tBreaking because of (%s, B%u) Rendertarget\n",
+ previous->fBatch->name(), previous->fBatch->uniqueID());
break;
}
// We cannot continue to search backwards if the render target changes
if (previous->fBatch->combineIfPossible(batch)) {
+ GrBATCH_INFO("\t\tCombining with (%s, B%u)\n",
+ previous->fBatch->name(), previous->fBatch->uniqueID());
return NULL;
}
if (intersect(previous->fBatch->bounds(), batch->bounds())) {
+ GrBATCH_INFO("\t\tIntersects with (%s, B%u)\n",
+ previous->fBatch->name(), previous->fBatch->uniqueID());
break;
}
} else if (Cmd::kClear_CmdType == reverseIter->type()) {
@@ -48,20 +74,35 @@ GrTargetCommands::Cmd* GrReorderCommandBuilder::recordDrawBatch(State* state, Gr
// We cannot continue to search backwards if the render target changes
if (previous->renderTarget() != rt) {
+ GrBATCH_INFO("\t\tBreaking because of Clear's Rendertarget change\n");
break;
}
// We set the color to illegal if we are doing a discard.
if (previous->fColor == GrColor_ILLEGAL ||
intersect(batch->bounds(), previous->fRect)) {
+ GrBATCH_INFO("\t\tBreaking because of Clear intersection\n");
break;
}
} else {
+ GrBATCH_INFO("\t\tBreaking because of other %08x\n", reverseIter->type());
// TODO temporary until we can navigate the other types of commands
break;
}
} while (reverseIter.previous() && ++i < kMaxLookback);
+#if GR_BATCH_SPEW
+ if (!reverseIter.get()) {
+ GrBATCH_INFO("\t\tNo more commands to try and batch with\n");
+ } else if (i >= kMaxLookback) {
+ GrBATCH_INFO("\t\tReached max lookback %d\n", i);
+ }
+#endif
+ }
+#if GR_BATCH_SPEW
+ else {
+ GrBATCH_INFO("\t\tBreaking because empty command buffer\n");
}
+#endif
return GrNEW_APPEND_TO_RECORDER(*this->cmdBuffer(), DrawBatch, (state, batch,
this->batchTarget()));
« no previous file with comments | « src/gpu/GrInOrderCommandBuilder.cpp ('k') | src/gpu/GrTargetCommands.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698