Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1276853003: Revert of Send GCM id to DMServer (Closed)

Created:
5 years, 4 months ago by binjin
Modified:
5 years, 4 months ago
CC:
chromium-reviews, jinzhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Send GCM id to DMServer (patchset #10 id:180001 of https://codereview.chromium.org/1258313002/ ) Reason for revert: protobuf change on server side. Original issue's description: > Send GCM id to DMServer > > This CL add a device management request to send GCM id after registration to > the server, so that server can maintain a mapping between GCM id and DM token. > > BUG=517466 > > Committed: https://crrev.com/92960c61ee75a5323fc954b9819acca5b684d2aa > Cr-Commit-Position: refs/heads/master@{#342364} TBR=jinzhang@chromium.org,atwilson@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=517466 Committed: https://crrev.com/e884c3ab04a7cb1901660f45dfba1c4223bbfa8d Cr-Commit-Position: refs/heads/master@{#342434}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -181 lines) Patch
M chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/heartbeat_scheduler.h View 4 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/chromeos/policy/heartbeat_scheduler.cc View 5 chunks +2 lines, -20 lines 0 comments Download
M chrome/browser/chromeos/policy/heartbeat_scheduler_unittest.cc View 6 chunks +4 lines, -32 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client.h View 2 chunks +0 lines, -14 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client.cc View 2 chunks +0 lines, -38 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_client_unittest.cc View 6 chunks +9 lines, -37 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/device_management_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/device_management_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/mock_cloud_policy_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/policy/proto/device_management_backend.proto View 6 chunks +2 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
binjin
Created Revert of Send GCM id to DMServer
5 years, 4 months ago (2015-08-07 20:44:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276853003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276853003/1
5 years, 4 months ago (2015-08-07 20:44:14 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 20:45:29 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 20:46:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e884c3ab04a7cb1901660f45dfba1c4223bbfa8d
Cr-Commit-Position: refs/heads/master@{#342434}

Powered by Google App Engine
This is Rietveld 408576698