Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: components/policy/core/common/cloud/cloud_policy_client.cc

Issue 1276853003: Revert of Send GCM id to DMServer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/cloud/cloud_policy_client.cc
diff --git a/components/policy/core/common/cloud/cloud_policy_client.cc b/components/policy/core/common/cloud/cloud_policy_client.cc
index f222db191d81fa3b119ed3691f9019c15fdee3ff..e2060fa0a67871344d3d8b6c4753edb1dcbd7508 100644
--- a/components/policy/core/common/cloud/cloud_policy_client.cc
+++ b/components/policy/core/common/cloud/cloud_policy_client.cc
@@ -372,30 +372,6 @@
const DeviceManagementRequestJob::Callback job_callback =
base::Bind(&CloudPolicyClient::OnDeviceAttributeUpdated,
base::Unretained(this), request_job.get(), callback);
-
- request_jobs_.push_back(request_job.Pass());
- request_jobs_.back()->Start(job_callback);
-}
-
-void CloudPolicyClient::UpdateGcmId(
- const std::string& gcm_id,
- const CloudPolicyClient::StatusCallback& callback) {
- CHECK(is_registered());
-
- scoped_ptr<DeviceManagementRequestJob> request_job(service_->CreateJob(
- DeviceManagementRequestJob::TYPE_GCM_ID_UPDATE, GetRequestContext()));
-
- request_job->SetDMToken(dm_token_);
- request_job->SetClientID(client_id_);
-
- em::GcmIdUpdateRequest* const request =
- request_job->GetRequest()->mutable_gcm_id_update_request();
-
- request->set_gcm_id(gcm_id);
-
- const DeviceManagementRequestJob::Callback job_callback =
- base::Bind(&CloudPolicyClient::OnGcmIdUpdated, base::Unretained(this),
- request_job.get(), callback);
request_jobs_.push_back(request_job.Pass());
request_jobs_.back()->Start(job_callback);
@@ -689,20 +665,6 @@
RemoveJob(job);
}
-void CloudPolicyClient::OnGcmIdUpdated(
- const DeviceManagementRequestJob* job,
- const StatusCallback& callback,
- DeviceManagementStatus status,
- int net_error,
- const enterprise_management::DeviceManagementResponse& response) {
- status_ = status;
- if (status != DM_STATUS_SUCCESS)
- NotifyClientError();
-
- callback.Run(status == DM_STATUS_SUCCESS);
- RemoveJob(job);
-}
-
void CloudPolicyClient::NotifyPolicyFetched() {
FOR_EACH_OBSERVER(Observer, observers_, OnPolicyFetched(this));
}

Powered by Google App Engine
This is Rietveld 408576698