Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 1276843006: Don't run platform diagnostics tool on invalid URLs from the renderer. (Closed)

Created:
5 years, 4 months ago by mmenke
Modified:
5 years, 4 months ago
Reviewers:
Elly Fong-Jones
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't run platform diagnostics tool on invalid URLs from the renderer. Not really a security issue, but just doesn't seem like a good idea. BUG=468037 Committed: https://crrev.com/6e98f5c0744522c2d7b2b5f4645962c263f293f5 Cr-Commit-Position: refs/heads/master@{#342357}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/net/net_error_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/net_error_tab_helper_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
mmenke
Should be an easy review. Note that localized_error.cc already checks for this before showing the ...
5 years, 4 months ago (2015-08-06 21:35:58 UTC) #2
Elly Fong-Jones
lgtm
5 years, 4 months ago (2015-08-07 14:20:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276843006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276843006/1
5 years, 4 months ago (2015-08-07 14:39:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 15:23:08 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 15:24:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e98f5c0744522c2d7b2b5f4645962c263f293f5
Cr-Commit-Position: refs/heads/master@{#342357}

Powered by Google App Engine
This is Rietveld 408576698