Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: chrome/browser/net/net_error_tab_helper_unittest.cc

Issue 1276843006: Don't run platform diagnostics tool on invalid URLs from the renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/net_error_tab_helper.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/net_error_tab_helper_unittest.cc
diff --git a/chrome/browser/net/net_error_tab_helper_unittest.cc b/chrome/browser/net/net_error_tab_helper_unittest.cc
index 05cfaa1cb6d5d4c48033349210ba5f27aa31c8c3..d8b9b5d8641f04533a7eaba79e15712a44ad0494 100644
--- a/chrome/browser/net/net_error_tab_helper_unittest.cc
+++ b/chrome/browser/net/net_error_tab_helper_unittest.cc
@@ -421,9 +421,12 @@ TEST_F(NetErrorTabHelperTest, SanitizeDiagnosticsUrl) {
tab_helper()->network_diagnostics_url());
}
-// Makes sure that diagnostics aren't run on URLS with non-HTTP/HTTPS schemes.
+// Makes sure that diagnostics aren't run on invalid URLs or URLs with
+// non-HTTP/HTTPS schemes.
TEST_F(NetErrorTabHelperTest, NoDiagnosticsForNonHttpSchemes) {
const char* kUrls[] = {
+ "",
+ "http",
"file:///blah/blah",
"chrome://blah/",
"about:blank",
« no previous file with comments | « chrome/browser/net/net_error_tab_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698