Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 1276573002: Tolerate weird cl_kernels modules on Mac OS X 10.11 (Closed)

Created:
5 years, 4 months ago by Mark Mentovai
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Tolerate weird cl_kernels modules on Mac OS X 10.11. The cl_kernels bug (Apple bug 20239912) in which cl_kernels modules show up with an __LD,__compact_unwind section inside the __TEXT segment, is still present in Mac OS X 10.11. This results in these warnings and a failure to load the module: [pid:tid:yyyymmdd,hhmmss.uuuuuu:WARNING mach_o_image_segment_reader.cc:142] section.segname incorrect in segment __TEXT, section __LD,__compact_unwind 3/6, load command 0x19 0/6, module cl_kernels, address 0x10e964000 BUG=crashpad:42 TEST=crashpad_snapshot_test ProcessReader.*Modules R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/cd1f8fa3d2f2c76802952beac71ad85f51bbf771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M snapshot/mac/mach_o_image_segment_reader.cc View 2 chunks +12 lines, -6 lines 0 comments Download
M snapshot/mac/process_reader_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
5 years, 4 months ago (2015-08-05 18:06:42 UTC) #2
Robert Sesek
LGTM
5 years, 4 months ago (2015-08-05 20:20:03 UTC) #3
Mark Mentovai
5 years, 4 months ago (2015-08-05 21:13:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cd1f8fa3d2f2c76802952beac71ad85f51bbf771 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698