Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Side by Side Diff: snapshot/mac/process_reader_test.cc

Issue 1276573002: Tolerate weird cl_kernels modules on Mac OS X 10.11 (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « snapshot/mac/mach_o_image_segment_reader.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 process_reader_threaded_child.Run(); 525 process_reader_threaded_child.Run();
526 } 526 }
527 527
528 TEST(ProcessReader, ChildSeveralThreads) { 528 TEST(ProcessReader, ChildSeveralThreads) {
529 const size_t kChildThreads = 64; 529 const size_t kChildThreads = 64;
530 ProcessReaderThreadedChild process_reader_threaded_child(kChildThreads); 530 ProcessReaderThreadedChild process_reader_threaded_child(kChildThreads);
531 process_reader_threaded_child.Run(); 531 process_reader_threaded_child.Run();
532 } 532 }
533 533
534 // cl_kernels images (OpenCL kernels) are weird. They’re not ld output and don’t 534 // cl_kernels images (OpenCL kernels) are weird. They’re not ld output and don’t
535 // exist as files on disk. On Mac OS X 10.10, their Mach-O structure isn’t 535 // exist as files on disk. On OS X 10.10 and 10.11, their Mach-O structure isn’t
536 // perfect. They show up loaded into many executables, so these quirks should be 536 // perfect. They show up loaded into many executables, so these quirks should be
537 // tolerated. 537 // tolerated.
538 // 538 //
539 // Create an object of this class to ensure that at least one cl_kernels image 539 // Create an object of this class to ensure that at least one cl_kernels image
540 // is present in a process, to be able to test that all of the process-reading 540 // is present in a process, to be able to test that all of the process-reading
541 // machinery tolerates them. On systems where cl_kernels modules have known 541 // machinery tolerates them. On systems where cl_kernels modules have known
542 // quirks, the image that an object of this class produces will also have those 542 // quirks, the image that an object of this class produces will also have those
543 // quirks. 543 // quirks.
544 // 544 //
545 // https://openradar.appspot.com/20239912 545 // https://openradar.appspot.com/20239912
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
829 ScopedOpenCLNoOpKernel ensure_cl_kernels; 829 ScopedOpenCLNoOpKernel ensure_cl_kernels;
830 ASSERT_NO_FATAL_FAILURE(ensure_cl_kernels.SetUp()); 830 ASSERT_NO_FATAL_FAILURE(ensure_cl_kernels.SetUp());
831 831
832 ProcessReaderModulesChild process_reader_modules_child; 832 ProcessReaderModulesChild process_reader_modules_child;
833 process_reader_modules_child.Run(); 833 process_reader_modules_child.Run();
834 } 834 }
835 835
836 } // namespace 836 } // namespace
837 } // namespace test 837 } // namespace test
838 } // namespace crashpad 838 } // namespace crashpad
OLDNEW
« no previous file with comments | « snapshot/mac/mach_o_image_segment_reader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698