Issue 1276503003: Web MIDI: Android Chrome is stuck if connected USB devices are not MIDI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1276503003: Web MIDI: Android Chrome is stuck if connected USB devices are not MIDI (Closed)

Created:
5 years, 4 months ago by Takashi Toyoshima

Modified:
5 years, 4 months ago

Reviewers:
yhirano

CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

Web MIDI: Android Chrome is stuck if connected USB devices are not MIDI UsbMidiDeviceFactoryAndroid.enumerateDevices should return false if there are connected USB devices, but they all are not MIDI. TBR=yhirano@chromium.org BUG=513134 Review URL: https://codereview.chromium.org/1253183006 Cr-Commit-Position: refs/heads/master@{#340883} (cherry picked from commit 1ca345ec017e8f50a75194f1dc3c846fb3cbe747) Committed: https://chromium.googlesource.com/chromium/src/+/a0c54b203fc20085812ebfa3f0808856efb9f455

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Takashi Toyoshima

5 years, 4 months ago (2015-08-06 06:16:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a0c54b203fc20085812ebfa3f0808856efb9f455 (presubmit successful).