Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253183006: Web MIDI: Android Chrome is stuck if connected USB devices are not MIDI (Closed)

Created:
5 years, 4 months ago by Takashi Toyoshima
Modified:
5 years, 4 months ago
Reviewers:
yhirano
CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Web MIDI: Android Chrome is stuck if connected USB devices are not MIDI UsbMidiDeviceFactoryAndroid.enumerateDevices should return false if there are connected USB devices, but they all are not MIDI. BUG=513134 Committed: https://crrev.com/1ca345ec017e8f50a75194f1dc3c846fb3cbe747 Cr-Commit-Position: refs/heads/master@{#340883}

Patch Set 1 #

Patch Set 2 : update method document #

Total comments: 2

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
Takashi Toyoshima
Can you take a look?
5 years, 4 months ago (2015-07-29 10:59:38 UTC) #2
yhirano
lgtm https://codereview.chromium.org/1253183006/diff/20001/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java File media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java (right): https://codereview.chromium.org/1253183006/diff/20001/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java#newcode131 media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java:131: return requested; [optional] You can use !mRequestedDevices.isEmpty() instead ...
5 years, 4 months ago (2015-07-29 11:05:08 UTC) #3
Takashi Toyoshima
Thanks!
5 years, 4 months ago (2015-07-29 11:09:45 UTC) #4
Takashi Toyoshima
https://codereview.chromium.org/1253183006/diff/20001/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java File media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java (right): https://codereview.chromium.org/1253183006/diff/20001/media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java#newcode131 media/midi/java/src/org/chromium/media/midi/UsbMidiDeviceFactoryAndroid.java:131: return requested; Aha. It can be an one line ...
5 years, 4 months ago (2015-07-29 11:09:51 UTC) #5
yhirano
lgtm. Thanks for the fix!
5 years, 4 months ago (2015-07-29 11:10:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1253183006/20002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1253183006/20002
5 years, 4 months ago (2015-07-29 11:12:28 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:20002)
5 years, 4 months ago (2015-07-29 13:19:33 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-07-29 13:20:16 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1ca345ec017e8f50a75194f1dc3c846fb3cbe747
Cr-Commit-Position: refs/heads/master@{#340883}

Powered by Google App Engine
This is Rietveld 408576698