Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1276333004: GrDrawVertices to batches (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : more #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+459 lines, -489 lines) Patch
M gm/beziereffects.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gm/convexpolyeffect.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gyp/gpu.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrDrawContext.cpp View 1 5 chunks +6 lines, -401 lines 0 comments Download
D src/gpu/GrTestBatch.h View 1 chunk +0 lines, -86 lines 0 comments Download
A src/gpu/batches/GrDrawVerticesBatch.h View 1 2 3 1 chunk +99 lines, -0 lines 0 comments Download
A src/gpu/batches/GrDrawVerticesBatch.cpp View 1 2 1 chunk +348 lines, -0 lines 0 comments Download
A + src/gpu/batches/GrTestBatch.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-07 19:27:52 UTC) #2
robertphillips
rslgtm
5 years, 4 months ago (2015-08-07 19:32:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276333004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276333004/40001
5 years, 4 months ago (2015-08-07 19:35:31 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-07 19:35:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/2558)
5 years, 4 months ago (2015-08-07 19:37:11 UTC) #8
robertphillips
lgtm
5 years, 4 months ago (2015-08-07 19:37:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276333004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276333004/60001
5 years, 4 months ago (2015-08-07 19:38:49 UTC) #12
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 19:46:29 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/2771b5617c0440de2e8b3a024e367553e8a99d70

Powered by Google App Engine
This is Rietveld 408576698