Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 127633002: Land Recent QUIC Changes. (Closed)

Created:
6 years, 11 months ago by ramant (doing other things)
Modified:
6 years, 11 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC Changes. Fix QUIC faster stats reporting memory leaks and crashes by changing lifetime once again. Now QuicAckNotify::DelegateInterface, one of the base classes of QuicFasterStatsGatherer, is ref-counted so QuicFasterStatsGatherer is guanrateed to be around until either faster stats reporting happens or the last ack is delivered by the QuicConnection. Merge internal change: 59228960 https://codereview.chromium.org/126543005/ Add a test requested by rch@ in cr/59053386 to replicate a potential DCHECK failure. Merge internal change: 59147972 https://codereview.chromium.org/127563002/ QUIC - Syncing with internal source code. Fixing the include order. Added missing OVERRIDE. Merge internal change: 59061118 https://codereview.chromium.org/127553002/ Make TimeWaitListManager use PacketWriter's socket writability state. Merge internal change: 59058066 https://codereview.chromium.org/127523002/ Make QuicPacketWriter keep track of socket writability; expose the underlying writer's state instead of keeping a separate variable in Dispatcher. Eventually we'll thread this to session/connection as suggested in a TODO. Merge internal change: 59055651 https://codereview.chromium.org/127503002/ Fix a QUIC DCHECK flakiness caused by not checking if a packet is pending before asserting that it's in the sent_packet_map. Merge internal change: 59053386 https://codereview.chromium.org/127003002/ QUIC Cleanup to remove pending_packets from QuicSentPacketManager and use a flag in unacked_packets_. Replaced FindOrNull and FindOrDie with find() call. Merge internal change: 59015729 https://codereview.chromium.org/126983002/ R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243619

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+443 lines, -314 lines) Patch
M net/quic/quic_ack_notifier.h View 3 chunks +11 lines, -3 lines 0 comments Download
M net/quic/quic_ack_notifier.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/quic/quic_ack_notifier_test.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M net/quic/quic_connection_test.cc View 26 chunks +40 lines, -36 lines 0 comments Download
M net/quic/quic_default_packet_writer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M net/quic/quic_default_packet_writer.cc View 4 chunks +13 lines, -1 line 0 comments Download
M net/quic/quic_packet_creator_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/quic_packet_writer.h View 1 chunk +7 lines, -0 lines 0 comments Download
M net/quic/quic_sent_packet_manager.h View 5 chunks +10 lines, -10 lines 0 comments Download
M net/quic/quic_sent_packet_manager.cc View 27 chunks +154 lines, -134 lines 0 comments Download
M net/quic/quic_sent_packet_manager_test.cc View 6 chunks +40 lines, -19 lines 0 comments Download
M net/quic/quic_session_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/test_tools/quic_sent_packet_manager_peer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_writer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_test_writer.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 4 chunks +9 lines, -2 lines 0 comments Download
M net/tools/quic/quic_default_packet_writer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_default_packet_writer.cc View 2 chunks +18 lines, -3 lines 0 comments Download
M net/tools/quic/quic_dispatcher.h View 3 chunks +2 lines, -8 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 6 chunks +14 lines, -9 lines 0 comments Download
M net/tools/quic/quic_dispatcher_test.cc View 4 chunks +30 lines, -1 line 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.h View 2 chunks +5 lines, -9 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager.cc View 4 chunks +17 lines, -19 lines 0 comments Download
M net/tools/quic/quic_time_wait_list_manager_test.cc View 8 chunks +18 lines, -14 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/tools/quic/test_tools/quic_dispatcher_peer.cc View 2 chunks +1 line, -5 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/server_thread.h View 2 chunks +3 lines, -7 lines 0 comments Download
M net/tools/quic/test_tools/server_thread.cc View 3 chunks +5 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ramant (doing other things)
6 years, 11 months ago (2014-01-08 04:26:51 UTC) #1
ramant (doing other things)
Updated the URL for the following change (git cl upload of changes, failed earlier for ...
6 years, 11 months ago (2014-01-08 04:33:50 UTC) #2
Ryan Hamilton
lgtm
6 years, 11 months ago (2014-01-08 04:46:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/127633002/1
6 years, 11 months ago (2014-01-08 07:28:32 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243185
6 years, 11 months ago (2014-01-08 08:39:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/127633002/1
6 years, 11 months ago (2014-01-08 16:46:27 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 19:02:05 UTC) #7
Message was sent while issue was closed.
Change committed as 243619

Powered by Google App Engine
This is Rietveld 408576698