Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Unified Diff: net/tools/quic/quic_time_wait_list_manager.cc

Issue 127633002: Land Recent QUIC Changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/tools/quic/quic_time_wait_list_manager.h ('k') | net/tools/quic/quic_time_wait_list_manager_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/tools/quic/quic_time_wait_list_manager.cc
diff --git a/net/tools/quic/quic_time_wait_list_manager.cc b/net/tools/quic/quic_time_wait_list_manager.cc
index 962dfa3cd302228c80ddc3ffa714466f3e96e637..d17d721059ca6d7a5d4627146b7c57e55ea79cc9 100644
--- a/net/tools/quic/quic_time_wait_list_manager.cc
+++ b/net/tools/quic/quic_time_wait_list_manager.cc
@@ -99,8 +99,7 @@ QuicTimeWaitListManager::QuicTimeWaitListManager(
kTimeWaitPeriod_(QuicTime::Delta::FromSeconds(kTimeWaitSeconds)),
guid_clean_up_alarm_(new GuidCleanUpAlarm(this)),
clock_(epoll_server_),
- writer_(writer),
- is_write_blocked_(false) {
+ writer_(writer) {
SetGuidCleanUpAlarm();
}
@@ -137,17 +136,17 @@ QuicVersion QuicTimeWaitListManager::GetQuicVersionFromGuid(QuicGuid guid) {
}
bool QuicTimeWaitListManager::OnCanWrite() {
- is_write_blocked_ = false;
- while (!is_write_blocked_ && !pending_packets_queue_.empty()) {
+ while (!pending_packets_queue_.empty()) {
QueuedPacket* queued_packet = pending_packets_queue_.front();
- WriteToWire(queued_packet);
- if (!is_write_blocked_) {
+ if (WriteToWire(queued_packet)) {
pending_packets_queue_.pop_front();
delete queued_packet;
+ } else {
+ break;
}
}
- return !is_write_blocked_;
+ return !writer_->IsWriteBlocked();
}
void QuicTimeWaitListManager::ProcessPacket(
@@ -206,22 +205,18 @@ void QuicTimeWaitListManager::SendPublicReset(
// Either sends the packet and deletes it or makes pending queue the
// owner of the packet.
void QuicTimeWaitListManager::SendOrQueuePacket(QueuedPacket* packet) {
- if (!is_write_blocked_) {
- // TODO(satyamshekhar): Handle packets that fail due to error other than
- // EAGAIN or EWOULDBLOCK.
- WriteToWire(packet);
- }
-
- if (is_write_blocked_) {
+ if (WriteToWire(packet)) {
+ delete packet;
+ } else {
// pending_packets_queue takes the ownership of the queued packet.
pending_packets_queue_.push_back(packet);
- } else {
- delete packet;
}
}
-void QuicTimeWaitListManager::WriteToWire(QueuedPacket* queued_packet) {
- DCHECK(!is_write_blocked_);
+bool QuicTimeWaitListManager::WriteToWire(QueuedPacket* queued_packet) {
+ if (writer_->IsWriteBlocked()) {
+ return false;
+ }
WriteResult result = writer_->WritePacket(
queued_packet->packet()->data(),
queued_packet->packet()->length(),
@@ -229,12 +224,15 @@ void QuicTimeWaitListManager::WriteToWire(QueuedPacket* queued_packet) {
queued_packet->client_address(),
this);
if (result.status == WRITE_STATUS_BLOCKED) {
- is_write_blocked_ = true;
+ // If blocked and unbuffered, return false to retry sending.
+ DCHECK(writer_->IsWriteBlocked());
+ return writer_->IsWriteBlockedDataBuffered();
} else if (result.status == WRITE_STATUS_ERROR) {
LOG(WARNING) << "Received unknown error while sending reset packet to "
<< queued_packet->client_address().ToString() << ": "
<< strerror(result.error_code);
}
+ return true;
}
void QuicTimeWaitListManager::SetGuidCleanUpAlarm() {
« no previous file with comments | « net/tools/quic/quic_time_wait_list_manager.h ('k') | net/tools/quic/quic_time_wait_list_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698