Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1276163003: Increase number of bits for trace buffer chunk index (Closed)

Created:
5 years, 4 months ago by Xianzhu
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, oystein (OOO til 10th of July), nednguyen(REVIEW IN OTHER ACC)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase number of bits for trace buffer chunk index The buffer for "record-as-much-as-possible" mode contains too many chunks whose chunk indices to be contained in the 16 bit chunk index. Increase chunk index to 26 bits. BUG=516056 R=brianderson@chromium.org TBR=dsinclair@chromium.org,nduca@chromium.org TEST=Compile time static_asserts Committed: https://crrev.com/0ba996473f611b4557ceb5162501dd0251f2d236 Cr-Commit-Position: refs/heads/master@{#342495}

Patch Set 1 #

Patch Set 2 : Correct number of bits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M base/trace_event/trace_buffer.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 1 1 chunk +5 lines, -2 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
5 years, 4 months ago (2015-08-07 19:56:44 UTC) #2
brianderson
lgtm, but I'm just pixel wrangling today and not an owner. Should we TBR this? ...
5 years, 4 months ago (2015-08-07 23:31:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1276163003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1276163003/20001
5 years, 4 months ago (2015-08-07 23:59:48 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-08 00:56:03 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 00:56:38 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ba996473f611b4557ceb5162501dd0251f2d236
Cr-Commit-Position: refs/heads/master@{#342495}

Powered by Google App Engine
This is Rietveld 408576698