base/trace_event/trace_event_impl.h - Issue 1276163003: Increase number of bits for trace buffer chunk index

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/trace_event_impl.h

Issue 1276163003: Increase number of bits for trace buffer chunk index (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correct number of bits Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/trace_event/trace_event_impl.h

diff --git a/base/trace_event/trace_event_impl.h b/base/trace_event/trace_event_impl.h

index 8e9b3b0a96e51a1dc85a11394f1455b64dda3462..0d66bb2f9eaa4b1aeac8be24f394fc6db04f5933 100644

--- a/base/trace_event/trace_event_impl.h

+++ b/base/trace_event/trace_event_impl.h

@@ -66,8 +66,11 @@ const int kTraceMaxNumArgs = 2;

struct TraceEventHandle {

uint32 chunk_seq;

- uint16 chunk_index;

- uint16 event_index;

+ // These numbers of bits must be kept consistent with

+ // TraceBufferChunk::kMaxTrunkIndex and

+ // TraceBufferChunk::kTraceBufferChunkSize (in trace_buffer.h).

+ unsigned chunk_index : 26;

+ unsigned event_index : 6;

};

class BASE_EXPORT TraceEvent {

« no previous file with comments | « base/trace_event/trace_buffer.h ('k') | base/trace_event/trace_log.cc » ('j') | no next file with comments »