Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1275853006: Fix some crashes in GN. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some crashes in GN. GN would read past the end of the file if the last line was a comment that didn't end in a newline. It also would get confused if an end-of-file was reached after an assignment or a unary operator. BUG=478169 Committed: https://crrev.com/693c60569dce46d5b1d5e2befcce95f9c8f171da Cr-Commit-Position: refs/heads/master@{#342417}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M tools/gn/parser.cc View 3 chunks +11 lines, -1 line 0 comments Download
M tools/gn/parser_unittest.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M tools/gn/tokenizer.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 4 months ago (2015-08-07 17:58:04 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275853006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275853006/1
5 years, 4 months ago (2015-08-07 18:14:43 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-07 18:29:35 UTC) #6
jam
lgtm
5 years, 4 months ago (2015-08-07 19:48:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275853006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275853006/1
5 years, 4 months ago (2015-08-07 19:50:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 19:55:24 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 19:56:02 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/693c60569dce46d5b1d5e2befcce95f9c8f171da
Cr-Commit-Position: refs/heads/master@{#342417}

Powered by Google App Engine
This is Rietveld 408576698