tools/gn/tokenizer.cc - Issue 1275853006: Fix some crashes in GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/tokenizer.cc

Issue 1275853006: Fix some crashes in GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/tokenizer.cc

diff --git a/tools/gn/tokenizer.cc b/tools/gn/tokenizer.cc

index be3223b5e145e48bfc4db5dc6311f88856557b70..db10f6ae094946c11b659aca6dea43f207459f61 100644

--- a/tools/gn/tokenizer.cc

+++ b/tools/gn/tokenizer.cc

@@ -128,7 +128,8 @@ std::vector<Token> Tokenizer::Run() {

location.line_number() ||

tokens_.back().location().char_offset() != location.char_offset())) {

type = Token::LINE_COMMENT;

- Advance(); // The current \n.

+ if (!at_end()) // Could be EOF.

+ Advance(); // The current \n.

// If this comment is separated from the next syntax element, then we

// want to tag it as a block comment. This will become a standalone

// statement at the parser level to keep this comment separate, rather

« no previous file with comments | « tools/gn/parser_unittest.cc ('k') | no next file » | no next file with comments »