Chromium Code Reviews| Index: content/public/common/media_stream_request.cc |
| diff --git a/content/public/common/media_stream_request.cc b/content/public/common/media_stream_request.cc |
| index 0a35bd783bf7b8c16fabf293022c9ba92f971869..7eadf9a6c1338032c6bb499734e701fea98a5ac9 100644 |
| --- a/content/public/common/media_stream_request.cc |
| +++ b/content/public/common/media_stream_request.cc |
| @@ -83,6 +83,20 @@ const MediaStreamDevice* MediaStreamDevices::FindById( |
| return NULL; |
| } |
| +MediaStreamDevice::AudioDeviceParameters::AudioDeviceParameters() |
| + : sample_rate(), channel_layout(), frames_per_buffer(), effects() {} |
| + |
|
jam
2015/09/10 19:24:19
can this be inlined?
ajm
2015/09/10 19:33:04
Both of these are chromium-style violations due to
|
| +MediaStreamDevice::AudioDeviceParameters::AudioDeviceParameters( |
| + int sample_rate, |
| + int channel_layout, |
| + int frames_per_buffer) |
| + : sample_rate(sample_rate), |
| + channel_layout(channel_layout), |
| + frames_per_buffer(frames_per_buffer), |
| + effects() {} |
| + |
| +MediaStreamDevice::AudioDeviceParameters::~AudioDeviceParameters() {} |
|
aluebs-chromium
2015/09/10 02:41:39
Is there a reason to have an empty destructor here
jam
2015/09/10 19:24:19
also wondering this..
ajm
2015/09/10 19:33:04
As above. I should have added a review comment abo
aluebs-chromium
2015/09/11 01:58:42
Oh, I see. Thank you for clarifying :)
|
| + |
| MediaStreamRequest::MediaStreamRequest( |
| int render_process_id, |
| int render_frame_id, |