Add a virtual beamforming audio device on ChromeOS.

content/public/common/media_stream_request.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/public/common/media_stream_request.h"
 
 #include "base/logging.h"
 
 namespace content {
 
@@ skipping 65 matching lines @@
 
 const MediaStreamDevice* MediaStreamDevices::FindById(
     const std::string& device_id) const {
   for (const_iterator iter = begin(); iter != end(); ++iter) {
     if (iter->id == device_id)
       return &(*iter);
   }
   return NULL;
 }
 
+MediaStreamDevice::AudioDeviceParameters::AudioDeviceParameters()
+    : sample_rate(), channel_layout(), frames_per_buffer(), effects() {}
+

[jam, 2015/09/10 19:24:19]

can this be inlined?

[ajm, 2015/09/10 19:33:04]

Both of these are chromium-style violations due to adding the vector member.
"Complex class/struct needs an explicit out-of-line {constructor,destructor}"

Described a bit here:
https://www.chromium.org/developers/coding-style/chromium-style-checker-errors

+MediaStreamDevice::AudioDeviceParameters::AudioDeviceParameters(
+    int sample_rate,
+    int channel_layout,
+    int frames_per_buffer)
+    : sample_rate(sample_rate),
+      channel_layout(channel_layout),
+      frames_per_buffer(frames_per_buffer),
+      effects() {}
+
+MediaStreamDevice::AudioDeviceParameters::~AudioDeviceParameters() {}

[aluebs-chromium, 2015/09/10 02:41:39]

Is there a reason to have an empty destructor here?

[jam, 2015/09/10 19:24:19]

also wondering this..

[ajm, 2015/09/10 19:33:04]

As above. I should have added a review comment about it.

[aluebs-chromium, 2015/09/11 01:58:42]

Oh, I see. Thank you for clarifying :)

+
 MediaStreamRequest::MediaStreamRequest(
     int render_process_id,
     int render_frame_id,
     int page_request_id,
     const GURL& security_origin,
     bool user_gesture,
     MediaStreamRequestType request_type,
     const std::string& requested_audio_device_id,
     const std::string& requested_video_device_id,
     MediaStreamType audio_type,
     MediaStreamType video_type)
     : render_process_id(render_process_id),
       render_frame_id(render_frame_id),
       page_request_id(page_request_id),
       security_origin(security_origin),
       user_gesture(user_gesture),
       request_type(request_type),
       requested_audio_device_id(requested_audio_device_id),
       requested_video_device_id(requested_video_device_id),
       audio_type(audio_type),
       video_type(video_type),
       all_ancestors_have_same_origin(false) {
 }
 
 MediaStreamRequest::~MediaStreamRequest() {}
 
 }  // namespace content