gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt - Issue 1275773003: gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

Issue 1275773003: gpu: support GL_TEXTURE_CUBE_MAP destination target to Copy(Sub)TextureCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix android build Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/android_video_decode_accelerator.cc ('k') | gpu/command_buffer/common/gles2_cmd_utils.h » ('j') | gpu/command_buffer/service/gles2_cmd_decoder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

diff --git a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

index be60af22dbbc309713ecfaed153ef25306dbbc0d..e45ad6f66bd45a7353d53be92ad39c4efbbfde46 100644

--- a/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

+++ b/gpu/GLES2/extensions/CHROMIUM/CHROMIUM_copy_texture.txt

@@ -82,7 +82,10 @@ New Procedures and Functions

INVALID_OPERATION is generated if the internal format of <source_id> is not one of

formats from the table above.

- INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.

+ INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D,

+ GL_TEXTURE_CUBE_MAP_POSITIVE_X, GL_TEXTURE_CUBE_MAP_NEGATIVE_X,

+ GL_TEXTURE_CUBE_MAP_POSITIVE_Y, GL_TEXTURE_CUBE_MAP_NEGATIVE_Y,

+ GL_TEXTURE_CUBE_MAP_POSITIVE_Z, or GL_TEXTURE_CUBE_MAP_NEGATIVE_Z.

INVALID_VALUE is generated if <source_id> or <dest_id> are not valid texture

objects.

@@ -126,7 +129,10 @@ New Procedures and Functions

INVALID_OPERATION is generated if source internal_format and destination

internal_format are not one of the valid formats described above.

- INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D.

+ INVALID_VALUE is generated if <target> is not GL_TEXTURE_2D,

+ GL_TEXTURE_CUBE_MAP_POSITIVE_X, GL_TEXTURE_CUBE_MAP_NEGATIVE_X,

+ GL_TEXTURE_CUBE_MAP_POSITIVE_Y, GL_TEXTURE_CUBE_MAP_NEGATIVE_Y,

+ GL_TEXTURE_CUBE_MAP_POSITIVE_Z, or GL_TEXTURE_CUBE_MAP_NEGATIVE_Z.

INVALID_OPERATION is generated if the destination texture has not been

defined.

@@ -163,3 +169,4 @@ Revision History

16/7/2014 Add GL_TEXTURE_RECTANGLE_ARB as valid source_id target

19/6/2015 Add arguments unpack_flip_y, unpack_premultiply_alpha, and

unpack_unmultiply_alpha to both commands.

+ 6/8/2015 support GL_TEXTURE_CUBE_MAP destination target.