Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1275753002: Rephrase Windows gyp instructions (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
mtklein, brucedawson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Rephrase Windows gyp instructions The existing instructions seem misleading. BUG=skia: NOTRY=true DOCS_PREVIEW= https://skia.org/?cl=1275753002 Committed: https://skia.googlesource.com/skia/+/1a3976795b2e3758ccec121771b890b6b10a648e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M site/user/quick/windows.md View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mtklein_C
5 years, 4 months ago (2015-08-05 23:11:05 UTC) #2
brucedawson
I am not an owner but lgtm.
5 years, 4 months ago (2015-08-05 23:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275753002/1
5 years, 4 months ago (2015-08-05 23:16:15 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-05 23:16:15 UTC) #6
mtklein
What, how silly. Luckily I am an owner...
5 years, 4 months ago (2015-08-05 23:17:07 UTC) #7
mtklein
lgtm
5 years, 4 months ago (2015-08-05 23:17:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275753002/1
5 years, 4 months ago (2015-08-05 23:17:32 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 23:18:06 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1a3976795b2e3758ccec121771b890b6b10a648e

Powered by Google App Engine
This is Rietveld 408576698