Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: site/user/quick/windows.md

Issue 1275753002: Rephrase Windows gyp instructions (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site/user/quick/windows.md
diff --git a/site/user/quick/windows.md b/site/user/quick/windows.md
index 53eb5d9a2e5097127d4e68ddfd609a5cd1e39910..fa00376064aae2bb492bfe24f1eaff769711f627 100644
--- a/site/user/quick/windows.md
+++ b/site/user/quick/windows.md
@@ -45,10 +45,16 @@ files.
You can generate the Visual Studio projects by running gyp_skia, as follows:
+ (setup GYP_GENERATORS, see just below)
cd %SKIA_CHECKOUT_DIR%
python gyp_skia
-This will produce Visual Studio projects in the `%SKIA_CHECKOUT_DIR%\out` directory.
+If you like to develop from a fully-integrated Visual Studio, set
+GYP_GENERATORS=ninja,msvs-ninja before running gyp_skia to generate
+Visual-Studio-compatible project files that still ultimately build using ninja,
+or set it to msvs to use Visual Studio's own (slower) build system. If you are
+comfortable with and prefer running ninja yourself, GYP_GENERATORS=ninja is
+considerably faster than the other two options.
Build and run tests from the command line
-----------------------------------------
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698