Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 1275743002: [Sync] Remove backend unrecoverable error handler (Closed)

Created:
5 years, 4 months ago by Nicolas Zea
Modified:
5 years, 4 months ago
Reviewers:
maxbogue, pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Remove backend unrecoverable error handler It was being used to allowed passing ownership of an error handler, but passing a weak handle works just as well. BUG=511235 Committed: https://crrev.com/e1c3d02433227b589fad049928b8a70157e9aecf Cr-Commit-Position: refs/heads/master@{#342384}

Patch Set 1 #

Patch Set 2 : Self review #

Patch Set 3 : Rebase #

Patch Set 4 : Fix SyncClient #

Patch Set 5 : Fix leak #

Patch Set 6 : Fix leak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -162 lines) Patch
D chrome/browser/sync/backend_unrecoverable_error_handler.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/sync/backend_unrecoverable_error_handler.cc View 1 chunk +0 lines, -31 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.h View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_mock.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.cc View 1 chunk +1 line, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M sync/internal_api/public/sync_manager.h View 3 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_backup_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sync/internal_api/sync_manager_impl.cc View 2 chunks +1 line, -2 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 2 3 4 5 4 chunks +5 lines, -10 lines 0 comments Download
M sync/internal_api/sync_rollback_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/sync_rollback_manager_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/sync_rollback_manager_base_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory.h View 2 chunks +7 lines, -6 lines 0 comments Download
M sync/syncable/directory.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M sync/syncable/directory_unittest.h View 1 chunk +1 line, -1 line 0 comments Download
M sync/syncable/directory_unittest.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M sync/syncable/syncable_unittest.cc View 8 chunks +20 lines, -16 lines 0 comments Download
M sync/test/engine/test_directory_setter_upper.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M sync/tools/sync_client.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M sync/util/mock_unrecoverable_error_handler.h View 2 chunks +5 lines, -0 lines 0 comments Download
M sync/util/mock_unrecoverable_error_handler.cc View 2 chunks +7 lines, -1 line 0 comments Download
M sync/util/test_unrecoverable_error_handler.h View 2 chunks +6 lines, -0 lines 0 comments Download
M sync/util/test_unrecoverable_error_handler.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 29 (15 generated)
Nicolas Zea
+Max, PTAL. This is basically a whole lot of plumbing of WeakHandles around.
5 years, 4 months ago (2015-08-05 22:36:35 UTC) #2
maxbogue
lgtm assuming bots pass. I haven't seen WeakHandles before; neat, and a nice solution to ...
5 years, 4 months ago (2015-08-05 23:23:56 UTC) #3
Nicolas Zea
+Pavel for committer review
5 years, 4 months ago (2015-08-06 21:05:51 UTC) #5
pavely
rs lgtm
5 years, 4 months ago (2015-08-06 21:08:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275743002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275743002/20001
5 years, 4 months ago (2015-08-06 21:13:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/82275) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-06 21:16:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275743002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275743002/40001
5 years, 4 months ago (2015-08-06 22:29:08 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/82331) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 4 months ago (2015-08-06 22:46:18 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275743002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275743002/60001
5 years, 4 months ago (2015-08-06 22:51:18 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/36975)
5 years, 4 months ago (2015-08-07 00:24:57 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275743002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275743002/80001
5 years, 4 months ago (2015-08-07 16:48:34 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275743002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275743002/100001
5 years, 4 months ago (2015-08-07 16:54:58 UTC) #27
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 4 months ago (2015-08-07 18:14:51 UTC) #28
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 18:15:30 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e1c3d02433227b589fad049928b8a70157e9aecf
Cr-Commit-Position: refs/heads/master@{#342384}

Powered by Google App Engine
This is Rietveld 408576698