sync/tools/sync_client.cc - Issue 1275743002: [Sync] Remove backend unrecoverable error handler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/tools/sync_client.cc

Issue 1275743002: [Sync] Remove backend unrecoverable error handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix leak Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/tools/sync_client.cc

diff --git a/sync/tools/sync_client.cc b/sync/tools/sync_client.cc

index 6c3793bdcc2bad52dcc9653698e64766a2bb7dab..2ec1f199f7cd1d303b4e3141665e3304893b4a8d 100644

--- a/sync/tools/sync_client.cc

+++ b/sync/tools/sync_client.cc

@@ -435,7 +435,7 @@ int SyncClientMain(int argc, char* argv[]) {

args.internal_components_factory.reset(

new InternalComponentsFactoryImpl(factory_switches));

args.encryptor = &null_encryptor;

- args.unrecoverable_error_handler.reset(new LoggingUnrecoverableErrorHandler);

+ args.unrecoverable_error_handler = WeakHandle<UnrecoverableErrorHandler>();

args.report_unrecoverable_error_function =

base::Bind(LogUnrecoverableErrorContext);

args.cancelation_signal = &scm_cancelation_signal;