tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py - Issue 1275613002: Telemetry android backend: re-raise BrowserGoneException instead of calling exit() when failing to …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py

Issue 1275613002: Telemetry android backend: re-raise BrowserGoneException instead of calling exit() when failing to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py

diff --git a/tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py b/tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py

index 3aadab34a9284d721dedbf361d605f7d39e7cd2a..9ae6629a7ffd0185f8201463a2b05de6445919c7 100644

--- a/tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py

+++ b/tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py

@@ -103,12 +103,9 @@ class AndroidMandolineBackend(

self._InitDevtoolsClientBackend(self._port)

except exceptions.BrowserGoneException:

logging.critical('Failed to connect to browser.')

- # TODO(yzshen): It seems wrong to catch exception and then exit, but this

- # matches the behavior of AndroidBrowserBackend. Consider fixing both.

- sys.exit(1)

+ self.Close()

+ raise

except:

- import traceback

- traceback.print_exc()

self.Close()

raise

« no previous file with comments | « tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py ('k') | no next file » | no next file with comments »