Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py

Issue 1275613002: Telemetry android backend: re-raise BrowserGoneException instead of calling exit() when failing to … (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
diff --git a/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py b/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
index 37874d484c44982d6ded459f255c6e9d27b092ab..d2c13dda6b9447c17279af86fd3d3b9acc4cbc18 100644
--- a/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
+++ b/tools/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
@@ -3,7 +3,6 @@
# found in the LICENSE file.
import logging
-import sys
from telemetry.core import exceptions
from telemetry.internal.platform import android_platform_backend as \
@@ -118,10 +117,9 @@ class AndroidBrowserBackend(chrome_browser_backend.ChromeBrowserBackend):
'(1) Flashing to a userdebug build OR '
'(2) Manually enabling web debugging in Chrome at '
'Settings > Developer tools > Enable USB Web debugging.')
- sys.exit(1)
+ self.Close()
+ raise
except:
- import traceback
- traceback.print_exc()
self.Close()
raise
« no previous file with comments | « no previous file | tools/telemetry/telemetry/internal/backends/mandoline/android_mandoline_backend.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698