Check for empty security info when sending security info to devtools

Check for empty security info when sending security info to devtools

Currently, some responses (notably, redirects) can come in to
WebURLLoader without any security info
attached. DeserializeSecurityInfo() does not treat empty strings as a
deserialization error, so in this case we end up trying to extract SSL
information from a connection status of 0. Instead, check for the
empty string upfront and just tell devtools that the security state is
unknown.

Hopefully, we will soon be attaching security info to redirect
responses (https://codereview.chromium.org/1275743005/).

BUG=519120
TBR=davidben@chromium.org

Committed: https://crrev.com/4c45ed01617e021bad654ff89e47fdcfc6c9ea18
Cr-Commit-Position: refs/heads/master@{#342794}

[estark, 2015-08-11 05:57:22]

estark@chromium.org changed reviewers:
+ davidben@chromium.org

[estark, 2015-08-11 05:57:23]

davidben: I'm TBRing this because it's a pretty simple fix for a problem that's
causing a lot of crashes when browsing with asserts enabled and devtools open,
which I gather is causing some infra issues (see the bug in the description).
Hope that's okay. Please take a look when you can.

[estark, 2015-08-11 05:57:28]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2015-08-11 05:57:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1275513006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1275513006/1

[estark, 2015-08-11 05:58:07]

+lgarron

[commit-bot: I haz the power, 2015-08-11 06:43:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-11 06:44:17]

Patchset 1 (id:??) landed as
https://crrev.com/4c45ed01617e021bad654ff89e47fdcfc6c9ea18
Cr-Commit-Position: refs/heads/master@{#342794}

[davidben, 2015-08-11 12:17:10]

lgtm

https://codereview.chromium.org/1275513006/diff/1/content/child/web_url_loade...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/1275513006/diff/1/content/child/web_url_loade...
content/child/web_url_loader_impl.cc:299: // info attached (such as a redirect
response).
(Huh, we don't send down security info in this case? An extension-simulated
redirect certainly would do it, but I would have thought it'd be available for
redirects.)

[estark, 2015-08-11 14:08:37]

On 2015/08/11 12:17:10, David Benjamin wrote:
> lgtm

Thanks!

> 
>
https://codereview.chromium.org/1275513006/diff/1/content/child/web_url_loade...
> File content/child/web_url_loader_impl.cc (right):
> 
>
https://codereview.chromium.org/1275513006/diff/1/content/child/web_url_loade...
> content/child/web_url_loader_impl.cc:299: // info attached (such as a redirect
> response).
> (Huh, we don't send down security info in this case? An extension-simulated
> redirect certainly would do it, but I would have thought it'd be available for
> redirects.)

Yeah, that is my understanding from looking at the code. Security info seems to
get attached in ResourceLoader::CompleteResponseStarted()
https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/lo...)
but not in ResourceLoader::OnReceivedRedirect(). See
https://codereview.chromium.org/1275743005/ where I'm proposing we add it there.