Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Unified Diff: content/child/web_url_loader_impl.cc

Issue 1275513006: Check for empty security info when sending security info to devtools (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/web_url_loader_impl.cc
diff --git a/content/child/web_url_loader_impl.cc b/content/child/web_url_loader_impl.cc
index 5b3db86661f8cf309f9db1673873493ba9188e45..c09713f64895a7a807f14a60483cb4240bd9fba3 100644
--- a/content/child/web_url_loader_impl.cc
+++ b/content/child/web_url_loader_impl.cc
@@ -295,6 +295,13 @@ void SetSecurityStyleAndDetails(const GURL& url,
return;
}
+ // There are cases where an HTTPS request can come in without security
+ // info attached (such as a redirect response).
davidben 2015/08/11 12:17:10 (Huh, we don't send down security info in this cas
+ if (security_info.empty()) {
+ response->setSecurityStyle(WebURLResponse::SecurityStyleUnknown);
+ return;
+ }
+
SSLStatus ssl_status;
if (!DeserializeSecurityInfo(security_info, &ssl_status)) {
response->setSecurityStyle(WebURLResponse::SecurityStyleUnknown);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698