Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1275383002: Revert of GC plugin: consider references equal to raw pointers. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken, sof
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of GC plugin: consider references equal to raw pointers. (patchset #2 id:20001 of https://codereview.chromium.org/1274403002/ ) Reason for revert: Turned the clang/win tot bots red: http://build.chromium.org/p/chromium.fyi/builders/ClangToTWin/builds/2327/steps/compile/logs/stdio ..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(13,1) : error: [blink-gc] Class 'CSSSupportsParser' contains invalid fields. class CSSSupportsParser { ^ ..\..\third_party\WebKit\Source\core/css/parser/CSSSupportsParser.h(31,5) : note: [blink-gc] Stack-allocated field 'm_parser' declared here: CSSParserImpl& m_parser; ^ Original issue's description: > GC plugin: consider references equal to raw pointers. > > Unmanaged raw pointers to managed(GC) classes aren't safe across GCs, > hence fields with raw pointer types to such GCed classes are identified > and reported as errors or warnings. > > Extend that checking to also apply to reference pointer types. > > R=haraken > BUG=420515 > > Committed: https://crrev.com/70fe23896f81cd66ba1a205b0336f91c64e3fa4e > Cr-Commit-Position: refs/heads/master@{#342320} TBR=oilpan-reviews@chromium.org,sigbjornf@opera.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=420515 Committed: https://crrev.com/488237f4eee9244e536acf8c71570df691f66b27 Cr-Commit-Position: refs/heads/master@{#342366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -74 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 9 chunks +8 lines, -47 lines 0 comments Download
M tools/clang/blink_gc_plugin/Edge.h View 2 chunks +2 lines, -11 lines 0 comments Download
M tools/clang/blink_gc_plugin/RecordInfo.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.h View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/raw_ptr_to_gc_managed_class.txt View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nico
Created Revert of GC plugin: consider references equal to raw pointers.
5 years, 4 months ago (2015-08-07 16:45:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275383002/1
5 years, 4 months ago (2015-08-07 16:45:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 16:46:10 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/488237f4eee9244e536acf8c71570df691f66b27 Cr-Commit-Position: refs/heads/master@{#342366}
5 years, 4 months ago (2015-08-07 16:46:57 UTC) #4
haraken
Thanks, LGTM
5 years, 4 months ago (2015-08-07 16:52:18 UTC) #5
sof
is clang/win a cq blocker? If/when a public/ lgtm transpires on https://codereview.chromium.org/1278103002/ , this would ...
5 years, 4 months ago (2015-08-07 17:44:48 UTC) #6
Nico
5 years, 4 months ago (2015-08-07 17:58:03 UTC) #7
Message was sent while issue was closed.
On 2015/08/07 17:44:48, sof wrote:
> is clang/win a cq blocker?

No. But none of the cq bots use a locally-compiled plugin, so the cq is useless
for plugin changes anyhow.

> If/when a public/ lgtm transpires on
https://codereview.chromium.org/1278103002/
> , this would go away.

Sounds good, please revert this revert once that happens :-)

Powered by Google App Engine
This is Rietveld 408576698