Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1275093002: [UMA, Cleanup] Remove an unneeded timing-related histogram. (Closed)

Created:
5 years, 4 months ago by Ilya Sherman
Modified:
5 years, 4 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, lcwu+watch_chromium.org, asvitkine+watch_chromium.org, gunsch+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[UMA, Cleanup] Remove an unneeded timing-related histogram. This histogram shows that the measured event is generally quite fast, and any future slowness should be identified with a profiler, rather than by remembering to check the histogram. BUG=517206 TEST=none R=asvitkine@chromium.org Committed: https://crrev.com/fcf5d24c6b47d9ad05ffd01cfbdb6fcd73e01136 Cr-Commit-Position: refs/heads/master@{#342376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/chromeos/external_metrics.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chromecast/browser/metrics/external_metrics.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Ilya Sherman
5 years, 4 months ago (2015-08-06 18:17:19 UTC) #1
Ilya Sherman
Though, I should note, that we seem some growth in the time taken on ChromeOS. ...
5 years, 4 months ago (2015-08-06 18:19:54 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 4 months ago (2015-08-06 18:20:49 UTC) #3
Alexei Svitkine (slow)
Even if it's growing, I personally don't really see a reason to worry about this ...
5 years, 4 months ago (2015-08-06 18:23:36 UTC) #4
Ilya Sherman
Xiyuan, mind rubber stamping the ChromeOS change?
5 years, 4 months ago (2015-08-06 18:32:24 UTC) #8
xiyuan
lgtm Happy to stamp.
5 years, 4 months ago (2015-08-06 19:34:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275093002/1
5 years, 4 months ago (2015-08-06 19:37:17 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89919)
5 years, 4 months ago (2015-08-06 21:01:52 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275093002/1
5 years, 4 months ago (2015-08-06 21:05:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89997)
5 years, 4 months ago (2015-08-06 22:13:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1275093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1275093002/1
5 years, 4 months ago (2015-08-07 17:19:47 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 17:54:31 UTC) #20
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 17:55:03 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcf5d24c6b47d9ad05ffd01cfbdb6fcd73e01136
Cr-Commit-Position: refs/heads/master@{#342376}

Powered by Google App Engine
This is Rietveld 408576698