Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Side by Side Diff: chromecast/browser/metrics/external_metrics.cc

Issue 1275093002: [UMA, Cleanup] Remove an unneeded timing-related histogram. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/chromeos/external_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/metrics/external_metrics.h" 5 #include "chromecast/browser/metrics/external_metrics.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
11 #include "base/files/file_util.h" 11 #include "base/files/file_util.h"
12 #include "base/metrics/histogram.h" 12 #include "base/metrics/histogram.h"
13 #include "base/metrics/sparse_histogram.h" 13 #include "base/metrics/sparse_histogram.h"
14 #include "base/metrics/statistics_recorder.h" 14 #include "base/metrics/statistics_recorder.h"
15 #include "base/timer/elapsed_timer.h"
16 #include "chromecast/base/metrics/cast_histograms.h" 15 #include "chromecast/base/metrics/cast_histograms.h"
17 #include "chromecast/base/metrics/cast_metrics_helper.h" 16 #include "chromecast/base/metrics/cast_metrics_helper.h"
18 #include "chromecast/browser/metrics/cast_stability_metrics_provider.h" 17 #include "chromecast/browser/metrics/cast_stability_metrics_provider.h"
19 #include "components/metrics/metrics_service.h" 18 #include "components/metrics/metrics_service.h"
20 #include "components/metrics/serialization/metric_sample.h" 19 #include "components/metrics/serialization/metric_sample.h"
21 #include "components/metrics/serialization/serialization_utils.h" 20 #include "components/metrics/serialization/serialization_utils.h"
22 #include "content/public/browser/browser_thread.h" 21 #include "content/public/browser/browser_thread.h"
23 22
24 namespace chromecast { 23 namespace chromecast {
25 namespace metrics { 24 namespace metrics {
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 case ::metrics::MetricSample::SPARSE_HISTOGRAM: 123 case ::metrics::MetricSample::SPARSE_HISTOGRAM:
125 RecordSparseHistogram(sample); 124 RecordSparseHistogram(sample);
126 break; 125 break;
127 } 126 }
128 } 127 }
129 128
130 return samples.size(); 129 return samples.size();
131 } 130 }
132 131
133 void ExternalMetrics::CollectEventsAndReschedule() { 132 void ExternalMetrics::CollectEventsAndReschedule() {
134 base::ElapsedTimer timer;
135 CollectEvents(); 133 CollectEvents();
136 UMA_HISTOGRAM_TIMES("UMA.CollectExternalEventsTime", timer.Elapsed());
137 ScheduleCollector(); 134 ScheduleCollector();
138 } 135 }
139 136
140 void ExternalMetrics::ScheduleCollector() { 137 void ExternalMetrics::ScheduleCollector() {
141 bool result = content::BrowserThread::PostDelayedTask( 138 bool result = content::BrowserThread::PostDelayedTask(
142 content::BrowserThread::FILE, 139 content::BrowserThread::FILE,
143 FROM_HERE, 140 FROM_HERE,
144 base::Bind(&ExternalMetrics::CollectEventsAndReschedule, 141 base::Bind(&ExternalMetrics::CollectEventsAndReschedule,
145 weak_factory_.GetWeakPtr()), 142 weak_factory_.GetWeakPtr()),
146 base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds)); 143 base::TimeDelta::FromSeconds(kExternalMetricsCollectionIntervalSeconds));
147 DCHECK(result); 144 DCHECK(result);
148 } 145 }
149 146
150 } // namespace metrics 147 } // namespace metrics
151 } // namespace chromecast 148 } // namespace chromecast
OLDNEW
« no previous file with comments | « chrome/browser/chromeos/external_metrics.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698