[tracing] Disable memory maps dump provider for security reason

base/trace_event/memory_dump_manager.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/trace_event/memory_dump_manager.h"
 
 #include <algorithm>
 
 #include "base/atomic_sequence_num.h"
 #include "base/command_line.h"
@@ skipping 100 matching lines @@
 
   if (skip_core_dumpers_auto_registration_for_testing_)
     return;
 
   // Enable the core dump providers.
 #if !defined(OS_NACL)
   RegisterDumpProvider(ProcessMemoryTotalsDumpProvider::GetInstance());
 #endif
 
 #if defined(OS_LINUX) || defined(OS_ANDROID)
-  g_mmaps_dump_provider = ProcessMemoryMapsDumpProvider::GetInstance();
-  RegisterDumpProvider(g_mmaps_dump_provider);
+  // The memory maps dump provider is currently disabled for security reasons
+  // and will be enabled once tracing is more secure (crbug.com/517906).
+  // It is still enabled for running benchmarks.
+  if (CommandLine::ForCurrentProcess()->HasSwitch(
+          "enable-memory-benchmarking")) {

[mdempsky, 2015/08/07 22:48:25]

Shouldn't this be switches::kEnableMemoryBenchmarking?

[ssid, 2015/08/07 22:58:06]

actually base does not know about content switches. But this file already seems
to use this switch like this. So, I am using here too.

[mdempsky, 2015/08/07 23:01:59]

Ah, fair point.

+    g_mmaps_dump_provider = ProcessMemoryMapsDumpProvider::GetInstance();
+    RegisterDumpProvider(g_mmaps_dump_provider);
+  }
+
   RegisterDumpProvider(MallocDumpProvider::GetInstance());
   system_allocator_pool_name_ = MallocDumpProvider::kAllocatedObjects;
 #endif
 
 #if defined(OS_ANDROID)
   RegisterDumpProvider(JavaHeapDumpProvider::GetInstance());
 #endif
 
 #if defined(OS_WIN)
   RegisterDumpProvider(WinHeapDumpProvider::GetInstance());
@@ skipping 349 matching lines @@
       next_dump_provider(next_dump_provider),
       callback(callback),
       task_runner(MessageLoop::current()->task_runner()) {
 }
 
 MemoryDumpManager::ProcessMemoryDumpAsyncState::~ProcessMemoryDumpAsyncState() {
 }
 
 }  // namespace trace_event
 }  // namespace base