Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1274913004: Revert of Android WebVR implementation, Cardboard 0.5.5 SDK (Closed)

Created:
5 years, 4 months ago by bajones
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android WebVR implementation, Cardboard 0.5.5 SDK (patchset #10 id:180001 of https://codereview.chromium.org/1200303002/ ) Reason for revert: Build config issue on ASAN bots. Original issue's description: > Android WebVR implementation, Cardboard 0.5.5 SDK > > Previously part of https://codereview.chromium.org/829803003/ > > BUG=389343 > > Committed: https://crrev.com/1d9c45547709e77d599c218d76317895389db129 > Cr-Commit-Position: refs/heads/master@{#342496} TBR=jochen@chromium.org,jdduke@chromium.org,sievers@chromium.org,tedchoc@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=389343 Committed: https://crrev.com/d94a4177c90960f0f75b5fca996414e2edd0f76c Cr-Commit-Position: refs/heads/master@{#342546}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -548 lines) Patch
M build/common.gypi View 1 chunk +3 lines, -8 lines 0 comments Download
M build/config/features.gni View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +0 lines, -5 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device.h View 1 chunk +0 lines, -38 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device.cc View 1 chunk +0 lines, -153 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device_provider.h View 1 chunk +0 lines, -33 lines 0 comments Download
D content/browser/vr/android/cardboard/cardboard_vr_device_provider.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M content/browser/vr/vr_device_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/vr/vr_device_manager.cc View 3 chunks +2 lines, -13 lines 0 comments Download
M content/browser/vr/vr_device_provider.h View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/vr/vr_transform_util.h View 1 chunk +0 lines, -17 lines 0 comments Download
D content/browser/vr/vr_transform_util.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D content/browser/vr/vr_transform_util_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M content/content.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -10 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +0 lines, -11 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/input/CardboardVRDevice.java View 1 chunk +0 lines, -88 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bajones
Created Revert of Android WebVR implementation, Cardboard 0.5.5 SDK
5 years, 4 months ago (2015-08-08 23:13:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274913004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274913004/1
5 years, 4 months ago (2015-08-08 23:13:18 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-08 23:13:41 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-08 23:14:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d94a4177c90960f0f75b5fca996414e2edd0f76c
Cr-Commit-Position: refs/heads/master@{#342546}

Powered by Google App Engine
This is Rietveld 408576698