Issue 1274803004: Merge to XFA: Remove dead code from CPDF_Metadata. Add missing nullptr check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1274803004: Merge to XFA: Remove dead code from CPDF_Metadata. Add missing nullptr check. (Closed)

Created:
5 years, 4 months ago by Lei Zhang

Modified:
5 years, 4 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove dead code from CPDF_Metadata. Add missing nullptr check. BUG=pdfium:117 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1282653002 . (cherry picked from commit 1e2ece0cf98f8daecdea5b45ebd20cedbcef4bd9) Committed: https://pdfium.googlesource.com/pdfium/+/119dc646ff7c108cc7319dbc11e05958d98fadfe

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -141 lines)			Patch
M	core/include/fpdfdoc/fpdf_doc.h	View	2 chunks	+8 lines, -11 lines	0 comments	Download
M	core/src/fpdfdoc/doc_metadata.cpp	View	1 chunk	+13 lines, -126 lines	0 comments	Download
M	fpdfsdk/src/fpdf_ext.cpp	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

TBR, not automatic because CPDF_Metadata::CPDF_Metadata() on the XFA branch still had a "Foo* foo = ...

5 years, 4 months ago (2015-08-11 21:08:43 UTC) #1

Lei Zhang

5 years, 4 months ago (2015-08-11 21:08:51 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
119dc646ff7c108cc7319dbc11e05958d98fadfe (presubmit successful).