Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282653002: Remove dead code from CPDF_Metadata. Add missing nullptr check. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dead code from CPDF_Metadata. Add missing nullptr check. BUG=pdfium:117 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1e2ece0cf98f8daecdea5b45ebd20cedbcef4bd9

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -139 lines) Patch
M core/include/fpdfdoc/fpdf_doc.h View 2 chunks +8 lines, -11 lines 0 comments Download
M core/src/fpdfdoc/doc_metadata.cpp View 1 chunk +13 lines, -124 lines 0 comments Download
M fpdfsdk/src/fpdf_ext.cpp View 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lei Zhang
5 years, 4 months ago (2015-08-08 01:59:05 UTC) #2
Lei Zhang
https://codereview.chromium.org/1282653002/diff/1/core/src/fpdfdoc/doc_metadata.cpp File core/src/fpdfdoc/doc_metadata.cpp (right): https://codereview.chromium.org/1282653002/diff/1/core/src/fpdfdoc/doc_metadata.cpp#newcode12 core/src/fpdfdoc/doc_metadata.cpp:12: if (!pRoot) To be clear, this is the part ...
5 years, 4 months ago (2015-08-11 20:26:23 UTC) #3
Tom Sepez
lgtm
5 years, 4 months ago (2015-08-11 20:33:28 UTC) #4
Lei Zhang
5 years, 4 months ago (2015-08-11 20:54:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1e2ece0cf98f8daecdea5b45ebd20cedbcef4bd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698