Modify languageSettingsPrivate IDL and flesh out stub implementation

Modify languageSettingsPrivate IDL and flesh out stub implementation

While implementing this API, I've come across some API changes I'd like to
make before submitting the actual implementation.

This also introduces the stub event router delegate and brings the stubs
closer to what the implementation looks like.

The implementation CL will be posted after this one:
  https://codereview.chromium.org/1283603002/

BUG=479043
Committed: https://crrev.com/958079e822f32b2dfe18b1bb95fbbec2684decc2
Cr-Commit-Position: refs/heads/master@{#343474}

[michaelpg, 2015-08-08 03:04:19]

Patchset #1 (id:1) has been deleted

[michaelpg, 2015-08-08 03:05:58]

michaelpg@chromium.org changed reviewers:
+ asvitkine@chromium.org, dbeam@chromium.org, kalman@chromium.org,
stevenjb@chromium.org

[michaelpg, 2015-08-08 03:09:24]

Patchset #1 (id:20001) has been deleted

[michaelpg, 2015-08-08 03:11:04]

PTAL!

stevenjb: everything

asvitkine: 
    extensions/browser/extension_event_histogram_value.h
    tools/metrics/histograms/histograms.xml

dbeam:
    third_party/closure_compiler/externs/language_settings_private.js
(generated)

kalman:
    chrome/browser/extensions/browser_context_keyed_service_factories.cc
    chrome/common/extensions/api/language_settings_private.idl

[Alexei Svitkine (slow), 2015-08-10 15:56:41]

lgtm

[stevenjb, 2015-08-10 15:57:20]

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/language_settings_private.idl (right):

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
chrome/common/extensions/api/language_settings_private.idl:19: boolean? rtl;
As long as we are renaming things, I would rename this something like
displayNameRTL.

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
chrome/common/extensions/api/language_settings_private.idl:22: boolean?
supportsUi;
I would leave this UI. With a TLA like RTL I could be convinced that Rtl is OK,
but with UI it looks really strange (and UI is way more common than Ui in our
existing JS).

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
chrome/common/extensions/api/language_settings_private.idl:78: callback
InputMethodAddedRemovedCallback = void (DOMString inputMethodId);
Unused

[not at google - send to devlin, 2015-08-10 17:01:04]

rs lgtm

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/language_settings_private.idl (right):

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
chrome/common/extensions/api/language_settings_private.idl:22: boolean?
supportsUi;
On 2015/08/10 15:57:20, stevenjb wrote:
> I would leave this UI. With a TLA like RTL I could be convinced that Rtl is
OK,
> but with UI it looks really strange (and UI is way more common than Ui in our
> existing JS).

+1 and I don't see the point of this little bit of churn anyway.

[michaelpg, 2015-08-10 22:34:52]

Patchset #2 (id:60001) has been deleted

[michaelpg, 2015-08-10 22:35:06]

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
File chrome/common/extensions/api/language_settings_private.idl (right):

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
chrome/common/extensions/api/language_settings_private.idl:19: boolean? rtl;
On 2015/08/10 15:57:20, stevenjb wrote:
> As long as we are renaming things, I would rename this something like
> displayNameRTL.

Done.

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
chrome/common/extensions/api/language_settings_private.idl:22: boolean?
supportsUi;
On 2015/08/10 15:57:20, stevenjb wrote:
> I would leave this UI. With a TLA like RTL I could be convinced that Rtl is
OK,
> but with UI it looks really strange (and UI is way more common than Ui in our
> existing JS).

Done. I guess I was thinking of the C++ naming guidelines.

https://codereview.chromium.org/1274753006/diff/40001/chrome/common/extension...
chrome/common/extensions/api/language_settings_private.idl:78: callback
InputMethodAddedRemovedCallback = void (DOMString inputMethodId);
On 2015/08/10 15:57:20, stevenjb wrote:
> Unused

Removed.

[stevenjb, 2015-08-10 22:48:27]

lgtm

[michaelpg, 2015-08-14 00:24:05]

dbeam: ping for externs

[Dan Beam, 2015-08-14 17:51:57]

lgtm

https://codereview.chromium.org/1274753006/diff/80001/third_party/closure_com...
File third_party/closure_compiler/externs/language_settings_private.js (left):

https://codereview.chromium.org/1274753006/diff/80001/third_party/closure_com...
third_party/closure_compiler/externs/language_settings_private.js:1:
language_settings_private_externs.js
@_@

[michaelpg, 2015-08-14 17:55:59]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2015-08-14 17:56:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1274753006/#ps80001
(title: "feedback")

[michaelpg, 2015-08-14 17:56:09]

https://codereview.chromium.org/1274753006/diff/80001/third_party/closure_com...
File third_party/closure_compiler/externs/language_settings_private.js (left):

https://codereview.chromium.org/1274753006/diff/80001/third_party/closure_com...
third_party/closure_compiler/externs/language_settings_private.js:1:
language_settings_private_externs.js
On 2015/08/14 17:51:57, Dan Beam wrote:
> @_@

Don't @_@ at me, @_@ at compiler.py --generator=externs.

[commit-bot: I haz the power, 2015-08-14 17:56:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274753006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274753006/80001

[commit-bot: I haz the power, 2015-08-14 17:57:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-14 17:57:39]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[michaelpg, 2015-08-14 19:19:07]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2015-08-14 19:19:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, asvitkine@chromium.org, dbeam@chromium.org,
kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1274753006/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2015-08-14 19:19:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274753006/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274753006/100001

[commit-bot: I haz the power, 2015-08-14 20:23:55]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2015-08-14 20:24:36]

Patchset 3 (id:??) landed as
https://crrev.com/958079e822f32b2dfe18b1bb95fbbec2684decc2
Cr-Commit-Position: refs/heads/master@{#343474}

[Ilya Sherman, 2015-09-10 00:12:08]

isherman@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2015-09-10 00:12:09]

https://codereview.chromium.org/1274753006/diff/100001/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/1274753006/diff/100001/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:56519: +  <int value="379"
There's a gap in your numbering here -- this should be 378.  If you added these
entries manually, for future reference, there's a script [1] that automates the
process.  If you added them using the script, that sounds like a pretty
worrisome bug, which we should fix...

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/hist...

[michaelpg, 2015-09-15 16:27:55]

On 2015/09/10 00:12:09, Ilya Sherman wrote:
>
https://codereview.chromium.org/1274753006/diff/100001/tools/metrics/histogra...
> File tools/metrics/histograms/histograms.xml (right):
> 
>
https://codereview.chromium.org/1274753006/diff/100001/tools/metrics/histogra...
> tools/metrics/histograms/histograms.xml:56519: +  <int value="379"
> There's a gap in your numbering here -- this should be 378.  If you added
these
> entries manually, for future reference, there's a script [1] that automates
the
> process.  If you added them using the script, that sounds like a pretty
> worrisome bug, which we should fix...
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/tools/metrics/hist...

Ah, sorry. I *thought* that I used the script but I did manually rebase. I
remember updating the numbers manually, at any rate, so I must've introduced the
error then.

Thanks for fixing. I'll be more careful next time and double-check before I
land.