Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc

Issue 1274753006: Modify languageSettingsPrivate IDL and flesh out stub implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
diff --git a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
index e470b410d223cc405fea2bbdff5a113736c818aa..ea03265a38f10b9956ef296fec17f35290b86010 100644
--- a/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
+++ b/chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
@@ -5,9 +5,12 @@
#include "chrome/browser/extensions/api/language_settings_private/language_settings_private_api.h"
#include "base/values.h"
+#include "chrome/common/extensions/api/language_settings_private.h"
namespace extensions {
+namespace language_settings_private = api::language_settings_private;
+
LanguageSettingsPrivateGetLanguageListFunction::
LanguageSettingsPrivateGetLanguageListFunction() {
}
@@ -31,33 +34,37 @@ LanguageSettingsPrivateSetLanguageListFunction::
ExtensionFunction::ResponseAction
LanguageSettingsPrivateSetLanguageListFunction::Run() {
- return RespondNow(OneArgument(new base::FundamentalValue(true)));
+ scoped_ptr<language_settings_private::SetLanguageList::Params> parameters =
+ language_settings_private::SetLanguageList::Params::Create(*args_);
+ EXTENSION_FUNCTION_VALIDATE(parameters.get());
+
+ return RespondNow(NoArguments());
}
-LanguageSettingsPrivateGetSpellCheckDictionaryStatusFunction::
- LanguageSettingsPrivateGetSpellCheckDictionaryStatusFunction() {
+LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction::
+ LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction() {
}
-LanguageSettingsPrivateGetSpellCheckDictionaryStatusFunction::
- ~LanguageSettingsPrivateGetSpellCheckDictionaryStatusFunction() {
+LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction::
+ ~LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction() {
}
ExtensionFunction::ResponseAction
-LanguageSettingsPrivateGetSpellCheckDictionaryStatusFunction::Run() {
- return RespondNow(OneArgument(new base::DictionaryValue()));
+LanguageSettingsPrivateGetSpellcheckDictionaryStatusesFunction::Run() {
+ return RespondNow(OneArgument(new base::ListValue()));
}
-LanguageSettingsPrivateGetSpellCheckWordsFunction::
- LanguageSettingsPrivateGetSpellCheckWordsFunction() {
+LanguageSettingsPrivateGetSpellcheckWordsFunction::
+ LanguageSettingsPrivateGetSpellcheckWordsFunction() {
}
-LanguageSettingsPrivateGetSpellCheckWordsFunction::
- ~LanguageSettingsPrivateGetSpellCheckWordsFunction() {
+LanguageSettingsPrivateGetSpellcheckWordsFunction::
+ ~LanguageSettingsPrivateGetSpellcheckWordsFunction() {
}
ExtensionFunction::ResponseAction
-LanguageSettingsPrivateGetSpellCheckWordsFunction::Run() {
- return RespondNow(OneArgument(new base::FundamentalValue(true)));
+LanguageSettingsPrivateGetSpellcheckWordsFunction::Run() {
+ return RespondNow(OneArgument(new base::ListValue()));
}
LanguageSettingsPrivateGetTranslateTargetLanguageFunction::

Powered by Google App Engine
This is Rietveld 408576698