Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1274513003: __ARM_NEON is defined both by ARMv8 and ARMv7 + -mfpu=neon. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
djsollen, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

__ARM_NEON is defined both by ARMv8 and ARMv7 + -mfpu=neon. Can't hurt to simplify a little. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/765d6ad975b56253c4b6aadd8721bff1fac2d827

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M include/core/SkPreConfig.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274513003/1
5 years, 4 months ago (2015-08-06 17:34:56 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-06 17:43:15 UTC) #4
mtklein_C
5 years, 4 months ago (2015-08-06 17:48:39 UTC) #6
djsollen
lgtm
5 years, 4 months ago (2015-08-06 18:15:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274513003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274513003/1
5 years, 4 months ago (2015-08-06 18:16:33 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-06 18:17:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/765d6ad975b56253c4b6aadd8721bff1fac2d827

Powered by Google App Engine
This is Rietveld 408576698