include/core/SkPreConfig.h - Issue 1274513003: __ARM_NEON is defined both by ARMv8 and ARMv7 + -mfpu=neon.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPreConfig.h

Issue 1274513003: __ARM_NEON is defined both by ARMv8 and ARMv7 + -mfpu=neon. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/core/SkPreConfig.h

diff --git a/include/core/SkPreConfig.h b/include/core/SkPreConfig.h

index 0715fc9ac6749d3c0c9094608d974ca3fafeb8ca..19363427a0213a4263325780b8f2b6aba6f5820b 100644

--- a/include/core/SkPreConfig.h

+++ b/include/core/SkPreConfig.h

@@ -188,8 +188,7 @@

// All 64-bit ARM chips have NEON. Many 32-bit ARM chips do too.

// TODO: Why don't we want NEON on iOS?

-#if !defined(SK_ARM_HAS_NEON) && !defined(SK_BUILD_FOR_IOS) && \

- (defined(SK_CPU_ARM64) || defined(__ARM_NEON__))

+#if !defined(SK_ARM_HAS_NEON) && !defined(SK_BUILD_FOR_IOS) && defined(__ARM_NEON)

#define SK_ARM_HAS_NEON

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »