Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1274433003: Add GetMimeTypeFromFile to Mojo's network service. (Closed)

Created:
5 years, 4 months ago by msw
Modified:
5 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, sky, Ryan Sleevi
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GetMimeTypeFromFile to Mojo's network service. This allows loading file:// URLs as html (etc.) content. This resolves https://codereview.chromium.org/1268993003 TODO. It's also a compromise of the following requirements: 1) Use net/base/mime_util.* to infer MIME from file paths. (we want a single robust and consistent inference of MIME types) 2) Do not move the mime_util code out of src/net. (net can't depend on components; this code doesn't belong in base) 3) Avoid using the network service to load file URLs. (we want to avoid file system access by the network service) BUG=513779 TEST=Mojo and Mandoline handle html (etc.) file URLs as expected. R=jam@chromium.org Committed: https://crrev.com/669dda3d77f4ba264569fa37e7f12aa3fffd4df1 Cr-Commit-Position: refs/heads/master@{#341998}

Patch Set 1 #

Patch Set 2 : Cleanup. #

Patch Set 3 : Fix Windows compile error. #

Patch Set 4 : Fix string usage and NativeApplicationLoaderTest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -17 lines) Patch
M mojo/runner/native_runner_unittest.cc View 1 2 3 3 chunks +9 lines, -3 lines 0 comments Download
M mojo/services/network/network_service_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/services/network/network_service_impl.cc View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M mojo/services/network/public/interfaces/network_service.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M mojo/shell/application_manager.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M mojo/shell/local_fetcher.h View 1 2 chunks +11 lines, -2 lines 0 comments Download
M mojo/shell/local_fetcher.cc View 1 2 3 chunks +17 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
msw
Hey John, please take a look; thanks!
5 years, 4 months ago (2015-08-04 20:41:53 UTC) #1
jam
lgtm
5 years, 4 months ago (2015-08-04 23:10:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274433003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274433003/20001
5 years, 4 months ago (2015-08-04 23:34:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/88624)
5 years, 4 months ago (2015-08-05 00:04:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274433003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274433003/40001
5 years, 4 months ago (2015-08-05 18:10:01 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/117887)
5 years, 4 months ago (2015-08-05 19:06:50 UTC) #11
msw
Hey John, please take a look at the latest patch set; thanks!
5 years, 4 months ago (2015-08-05 21:49:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274433003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274433003/60001
5 years, 4 months ago (2015-08-05 21:51:02 UTC) #15
jam
lgtm
5 years, 4 months ago (2015-08-05 21:54:04 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-05 22:55:15 UTC) #17
commit-bot: I haz the power
5 years, 4 months ago (2015-08-05 22:55:54 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/669dda3d77f4ba264569fa37e7f12aa3fffd4df1
Cr-Commit-Position: refs/heads/master@{#341998}

Powered by Google App Engine
This is Rietveld 408576698