Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1268993003: Support loading html file URLs in Mojo. (Closed)

Created:
5 years, 4 months ago by msw
Modified:
5 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Support loading html file URLs in Mojo. Set the mime_type on LocalFetcher's URLResponsePtr. Infer text/html from related file path extensions. TODO: Expand support; use net::GetMimeTypeFromExtension. BUG=513779 TEST=Running "out/Debug/Mandoline file://<local URL>.html works. R=sky@chromium.org Committed: https://crrev.com/a28de6accdb7d5af2aa203208fe8d35104b3abd1 Cr-Commit-Position: refs/heads/master@{#341631}

Patch Set 1 #

Patch Set 2 : Debugging LocalFetcher issue. #

Patch Set 3 : Set LocalFetcher's URLResponsePtr::mime_type. #

Patch Set 4 : Cleanup, add other html extensions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M mojo/shell/local_fetcher.cc View 1 2 3 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
msw
Hey Scott, please take a look; thanks!
5 years, 4 months ago (2015-08-03 20:50:59 UTC) #2
sky
LGTM
5 years, 4 months ago (2015-08-03 21:41:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1268993003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1268993003/60001
5 years, 4 months ago (2015-08-03 21:49:33 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-08-03 22:28:51 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-03 22:29:19 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a28de6accdb7d5af2aa203208fe8d35104b3abd1
Cr-Commit-Position: refs/heads/master@{#341631}

Powered by Google App Engine
This is Rietveld 408576698