PDF: Use the z-order when there is a link and widget overlaps.

PDF: Use the z-order when there is a link and widget overlaps.

BUG=515837
Committed: https://crrev.com/b2ebd3e75989a75ac356e5560a1fd542481e830d
Cr-Commit-Position: refs/heads/master@{#343574}

[Lei Zhang, 2015-08-07 07:47:12]

thestig@chromium.org changed reviewers:
+ tsepez@google.com

[Lei Zhang, 2015-08-07 07:47:12]

Requires https://codereview.chromium.org/1278053004

[tsepez (do not use), 2015-08-07 18:15:09]

tsepez@google.com changed reviewers:
+ tsepez@chromium.org
- tsepez@google.com

[Tom Sepez, 2015-08-07 18:19:13]

lgtm

https://codereview.chromium.org/1274413002/diff/1/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/1274413002/diff/1/pdf/pdfium/pdfium_page.cc#n...
pdf/pdfium/pdfium_page.cc:266: double new_x, new_y;
nit: one per line.

[Tom Sepez, 2015-08-07 18:20:14]

https://codereview.chromium.org/1274413002/diff/1/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/1274413002/diff/1/pdf/pdfium/pdfium_page.cc#n...
pdf/pdfium/pdfium_page.cc:311: return GetLink(*char_index, target) != -1 ?
WEBLINK_AREA : TEXT_AREA;
nit: seems like a double negative here.

[Lei Zhang, 2015-08-07 23:39:42]

https://codereview.chromium.org/1274413002/diff/1/pdf/pdfium/pdfium_page.cc
File pdf/pdfium/pdfium_page.cc (right):

https://codereview.chromium.org/1274413002/diff/1/pdf/pdfium/pdfium_page.cc#n...
pdf/pdfium/pdfium_page.cc:266: double new_x, new_y;
On 2015/08/07 18:19:13, Tom Sepez wrote:
> nit: one per line.

Done.

https://codereview.chromium.org/1274413002/diff/1/pdf/pdfium/pdfium_page.cc#n...
pdf/pdfium/pdfium_page.cc:311: return GetLink(*char_index, target) != -1 ?
WEBLINK_AREA : TEXT_AREA;
On 2015/08/07 18:20:14, Tom Sepez wrote:
> nit: seems like a double negative here.

Seems ok to me. "If GetLink() succeeds, it's a web-link area"

[Lei Zhang, 2015-08-15 04:21:21]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-08-15 04:21:22]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1274413002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2015-08-15 04:21:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274413002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274413002/60001

[commit-bot: I haz the power, 2015-08-15 05:13:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-08-15 05:13:50]

Patchset 4 (id:??) landed as
https://crrev.com/b2ebd3e75989a75ac356e5560a1fd542481e830d
Cr-Commit-Position: refs/heads/master@{#343574}