Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1274)

Issue 1274383002: Remove deprecated CONTENT_SETTINGS_TYPE_METRO_SWITCH_TO_DESKTOP content setting (Closed)

Created:
5 years, 4 months ago by raymes
Modified:
5 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, markusheintz_, michaelpg+watch-options_chromium.org, jam, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated CONTENT_SETTINGS_TYPE_METRO_SWITCH_TO_DESKTOP content setting This content setting was used for a "Don't ask again" button on the Metro mode infobar, but it appears that got removed at the behest of UI review (https://codereview.chromium.org/23591005) a while ago, so we can remove the setting completely. BUG=512683 Committed: https://crrev.com/58a07059347a10730c3d0e70bbc189c1c21bae49 Cr-Commit-Position: refs/heads/master@{#342572}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -37 lines) Patch
M chrome/browser/plugins/plugin_observer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M components/content_settings/core/browser/content_settings_policy_provider.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M components/content_settings/core/browser/website_settings_registry.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/content_settings/core/common/content_settings.cc View 2 chunks +1 line, -7 lines 0 comments Download
M components/content_settings/core/common/content_settings_types.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
raymes
Thanks for the info Bernhard.
5 years, 4 months ago (2015-08-07 00:57:52 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274383002/1
5 years, 4 months ago (2015-08-07 00:58:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/96262) win_chromium_x64_rel_ng on ...
5 years, 4 months ago (2015-08-07 01:41:04 UTC) #6
Bernhard Bauer
LGTM!
5 years, 4 months ago (2015-08-07 07:57:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274383002/20001
5 years, 4 months ago (2015-08-10 00:19:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-10 01:19:39 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 01:20:13 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/58a07059347a10730c3d0e70bbc189c1c21bae49
Cr-Commit-Position: refs/heads/master@{#342572}

Powered by Google App Engine
This is Rietveld 408576698