Issue 23591005: Update infobar buttons when attempting to run an NPAPI plugin in ash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23591005: Update infobar buttons when attempting to run an NPAPI plugin in ash. (Closed)

Created:
7 years, 3 months ago by zturner

Modified:
7 years, 3 months ago

Reviewers:
Bernhard Bauer, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, stuartmorgan+watch_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Update infobar buttons when attempting to run an NPAPI plugin in ash. Although UI review suggested to change the text to "Open Chrome on the Desktop", we already have (and are using in other situations) a string for "Relaunch Chrome on the Desktop". I used this string instead to avoid having to get anything re-translated. If we really need it to say Open, I will create a new string. BUG=230127 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221042

Patch Set 1 #

Patch Set 2 : Change string to say open. #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -19 lines)			Patch
M	chrome/app/generated_resources.grd	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/plugins/plugin_infobar_delegates.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/plugins/plugin_infobar_delegates.cc	View	1	2 chunks	+2 lines, -15 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

zturner

On 2013/08/28 17:58:35, cpu wrote: > I believe they really want 'Open' Done

7 years, 3 months ago (2013-08-29 17:59:12 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zturner@chromium.org/23591005/6001

7 years, 3 months ago (2013-09-03 19:33:17 UTC) #6

Message was sent while issue was closed.

Change committed as 221042

Expand Messages | Collapse Messages