Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 1274273003: Oilpan: handle MediaControls like the GCed object it is. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/shadow/MediaControls.cpp
diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp
index a5e5b17f191fc9f20d1333e4ef55e106e9602295..6c637b501bb2f9c087b8488cae820e12120cf9af 100644
--- a/Source/core/html/shadow/MediaControls.cpp
+++ b/Source/core/html/shadow/MediaControls.cpp
@@ -69,8 +69,10 @@ static bool preferHiddenVolumeControls(const Document& document)
class MediaControls::BatchedControlUpdate {
WTF_MAKE_NONCOPYABLE(BatchedControlUpdate);
+ STACK_ALLOCATED();
public:
- BatchedControlUpdate(MediaControls* controls) : m_controls(controls)
+ explicit BatchedControlUpdate(MediaControls* controls)
+ : m_controls(controls)
{
ASSERT(isMainThread());
ASSERT(s_batchDepth >= 0);
@@ -85,7 +87,7 @@ public:
}
private:
- MediaControls* m_controls;
+ RawPtrWillBeMember<MediaControls> m_controls;
static int s_batchDepth;
};

Powered by Google App Engine
This is Rietveld 408576698