Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: Source/core/html/shadow/MediaControlElementTypes.h

Issue 1274273003: Oilpan: handle MediaControls like the GCed object it is. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/shadow/MediaControlElementTypes.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControlElementTypes.h
diff --git a/Source/core/html/shadow/MediaControlElementTypes.h b/Source/core/html/shadow/MediaControlElementTypes.h
index 538395a68972872d8f4edb6422fbf56cc0694621..e5f33e71589b29bdb5914f46aa690b5131726759 100644
--- a/Source/core/html/shadow/MediaControlElementTypes.h
+++ b/Source/core/html/shadow/MediaControlElementTypes.h
@@ -92,7 +92,11 @@ public:
protected:
MediaControlElement(MediaControls&, MediaControlElementType, HTMLElement*);
- MediaControls& mediaControls() const { return m_mediaControls; }
+ MediaControls& mediaControls() const
+ {
+ ASSERT(m_mediaControls);
+ return *m_mediaControls;
+ }
HTMLMediaElement& mediaElement() const;
void setDisplayType(MediaControlElementType);
@@ -102,7 +106,7 @@ private:
// if and only if we're wanted and we fit.
void updateShownState();
- MediaControls& m_mediaControls;
+ RawPtrWillBeMember<MediaControls> m_mediaControls;
sof 2015/08/07 05:13:23 Notice that the removal of raw pointer effort does
MediaControlElementType m_displayType;
RawPtrWillBeMember<HTMLElement> m_element;
bool m_isWanted : 1;
« no previous file with comments | « no previous file | Source/core/html/shadow/MediaControlElementTypes.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698