Oilpan: handle MediaControls like the GCed object it is.

Oilpan: handle MediaControls like the GCed object it is.

R=haraken
BUG=340522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200148

[sof, 2015-08-06 20:58:05]

sigbjornf@opera.com changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-08-06 20:58:05]

please take a look.

[haraken, 2015-08-06 23:27:39]

LGTM

[sof, 2015-08-07 05:09:43]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2015-08-07 05:10:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1274273003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1274273003/1

[sof, 2015-08-07 05:13:23]

https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
File Source/core/html/shadow/MediaControlElementTypes.h (right):

https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
Source/core/html/shadow/MediaControlElementTypes.h:109:
RawPtrWillBeMember<MediaControls> m_mediaControls;
Notice that the removal of raw pointer effort doesn't encompass references.

[haraken, 2015-08-07 05:26:43]

On 2015/08/07 05:13:23, sof wrote:
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> File Source/core/html/shadow/MediaControlElementTypes.h (right):
> 
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> Source/core/html/shadow/MediaControlElementTypes.h:109:
> RawPtrWillBeMember<MediaControls> m_mediaControls;
> Notice that the removal of raw pointer effort doesn't encompass references.

Yeah, we need a plugin support to find them...

[Peter Beverloo, 2015-08-07 05:31:20]

On 2015/08/07 05:26:43, haraken wrote:
> On 2015/08/07 05:13:23, sof wrote:
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > File Source/core/html/shadow/MediaControlElementTypes.h (right):
> > 
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > Source/core/html/shadow/MediaControlElementTypes.h:109:
> > RawPtrWillBeMember<MediaControls> m_mediaControls;
> > Notice that the removal of raw pointer effort doesn't encompass references.
> 
> Yeah, we need a plugin support to find them...

fwiw, a code search query provides a good start:

https://code.google.com/p/chromium/codesearch#search/&q=pcre:yes%20f:.h$%20%5...

Looks like the PagePopupController is in the same boat as this class.

[sof, 2015-08-07 05:34:42]

On 2015/08/07 05:26:43, haraken wrote:
> On 2015/08/07 05:13:23, sof wrote:
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > File Source/core/html/shadow/MediaControlElementTypes.h (right):
> > 
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > Source/core/html/shadow/MediaControlElementTypes.h:109:
> > RawPtrWillBeMember<MediaControls> m_mediaControls;
> > Notice that the removal of raw pointer effort doesn't encompass references.
> 
> Yeah, we need a plugin support to find them...

As an approx, generate a raw set of candidates via grep should pick out many.

There's a number of them around, e.g.,

 foo$ git grep '& m_' Source/ | grep -v '(' | grep -v 'return' | grep -v '==' |
grep -v '//'

[commit-bot: I haz the power, 2015-08-07 05:50:47]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200148

[sof, 2015-08-07 05:58:39]

On 2015/08/07 05:34:42, sof wrote:
> On 2015/08/07 05:26:43, haraken wrote:
> > On 2015/08/07 05:13:23, sof wrote:
> > >
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > > File Source/core/html/shadow/MediaControlElementTypes.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > > Source/core/html/shadow/MediaControlElementTypes.h:109:
> > > RawPtrWillBeMember<MediaControls> m_mediaControls;
> > > Notice that the removal of raw pointer effort doesn't encompass
references.
> > 
> > Yeah, we need a plugin support to find them...
> 
> As an approx, generate a raw set of candidates via grep should pick out many.
> 
> There's a number of them around, e.g.,
> 
>  foo$ git grep '& m_' Source/ | grep -v '(' | grep -v 'return' | grep -v '=='
|
> grep -v '//'

If no one else is, I can update the GC plugin.

[haraken, 2015-08-07 06:03:25]

On 2015/08/07 05:58:39, sof wrote:
> On 2015/08/07 05:34:42, sof wrote:
> > On 2015/08/07 05:26:43, haraken wrote:
> > > On 2015/08/07 05:13:23, sof wrote:
> > > >
> > >
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > > > File Source/core/html/shadow/MediaControlElementTypes.h (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1274273003/diff/1/Source/core/html/shadow/Med...
> > > > Source/core/html/shadow/MediaControlElementTypes.h:109:
> > > > RawPtrWillBeMember<MediaControls> m_mediaControls;
> > > > Notice that the removal of raw pointer effort doesn't encompass
> references.
> > > 
> > > Yeah, we need a plugin support to find them...
> > 
> > As an approx, generate a raw set of candidates via grep should pick out
many.
> > 
> > There's a number of them around, e.g.,
> > 
> >  foo$ git grep '& m_' Source/ | grep -v '(' | grep -v 'return' | grep -v
'=='
> |
> > grep -v '//'
> 
> If no one else is, I can update the GC plugin.

Thanks!!!!

[sof, 2015-08-07 11:10:24]

With the GC plugin extended to report references also,
https://docs.google.com/spreadsheets/d/1VWmeQyPGQ96T8gN8dcqDJWIkV0C9S80hG6XbT...
has been updated.