Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1274263005: Roll pdfium to 905cc10ecd. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, Tom Sepez
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll pdfium to 905cc10ecd. https://codereview.chromium.org/1259123005 broke the clang/win bots thusly: ..\..\third_party\pdfium\core\src\fxge\ge\fx_ge_fontmap.cpp(456,7) : error: field 'm_pFontInfo' will be initialized after field 'm_bListLoaded' [-Werror,-Wreorder] : m_pFontInfo(nullptr), ^ 905cc10 fixed this, so roll pdfium forward in the hope of fixing the clang/win bots. 905cc10 Add CFX_FontFaceInfo constructor. 2526930 Early object closing in PDF via premature 'endobj' keyword 8d8a990 Remove the unused IFX_StreamRead::SetRange() mechanism. 2b91781 CPDF_Parser shouldnt be in the business of opening files 5cd3985 FPDF_Creator can only create file through embedder-supplied callback. BUG=82385, 493126 R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/7c900e6e00f63108f144cf0435097c7d953c04ff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
5 years, 4 months ago (2015-08-06 20:50:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1274263005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1274263005/1
5 years, 4 months ago (2015-08-06 20:50:35 UTC) #3
Lei Zhang
lgtm Also BUG=493126
5 years, 4 months ago (2015-08-06 20:53:23 UTC) #4
Nico
On 2015/08/06 20:53:23, Lei Zhang wrote: > lgtm > > Also BUG=493126 (i think you ...
5 years, 4 months ago (2015-08-06 20:59:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/89988)
5 years, 4 months ago (2015-08-06 22:01:58 UTC) #7
Nico
5 years, 4 months ago (2015-08-06 22:12:16 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7c900e6e00f63108f144cf0435097c7d953c04ff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698