Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 1259123005: Kill IFX_FontMapper (Closed)

Created:
5 years, 4 months ago by Tom Sepez
Modified:
5 years, 4 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kill IFX_FontMapper The design envisioned two kinds of font mappers: internal (of type CFX_FontMapper), and external, both of which implement a common interface. But there isn't any means of making an external one, so the interface is redundant. IFX_FontMapper also appears in an apple-specific struct, but was never non-null or used in any way. The CFX_FontMapper class provides its own mechanism to include platform-specific features, as it turns out. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/01fa1efb228acdcf5250804c670107133668e4b2

Patch Set 1 #

Total comments: 2

Patch Set 2 : blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -52 lines) Patch
M core/include/fxge/fx_font.h View 1 5 chunks +7 lines, -18 lines 0 comments Download
M core/include/fxge/fx_ge.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/src/fxge/apple/apple_int.h View 1 chunk +3 lines, -9 lines 0 comments Download
M core/src/fxge/ge/fx_ge.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M core/src/fxge/ge/fx_ge_fontmap.cpp View 3 chunks +9 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, for review.
5 years, 4 months ago (2015-07-31 19:56:16 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1259123005/diff/1/core/include/fxge/fx_font.h File core/include/fxge/fx_font.h (right): https://codereview.chromium.org/1259123005/diff/1/core/include/fxge/fx_font.h#newcode249 core/include/fxge/fx_font.h:249: CFX_FontMapper(CFX_FontMgr* mgr); explicit https://codereview.chromium.org/1259123005/diff/1/core/include/fxge/fx_font.h#newcode284 core/include/fxge/fx_font.h:284: Extra blank line ...
5 years, 4 months ago (2015-07-31 20:23:30 UTC) #3
Tom Sepez
5 years, 4 months ago (2015-07-31 21:00:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
01fa1efb228acdcf5250804c670107133668e4b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698