Add instrumentation to track the IceCandidatePairType and IceConnectionState

content/renderer/media/rtc_peer_connection_handler.h

Index: content/renderer/media/rtc_peer_connection_handler.h
diff --git a/content/renderer/media/rtc_peer_connection_handler.h b/content/renderer/media/rtc_peer_connection_handler.h
index 95846af2ae772566eea948a4975fc5203156da75..7c5a105618995f9eb1933fbac8ed41dc60cb9699 100644
--- a/content/renderer/media/rtc_peer_connection_handler.h
+++ b/content/renderer/media/rtc_peer_connection_handler.h
@@ -204,6 +204,15 @@ class CONTENT_EXPORT RTCPeerConnectionHandler
       const std::string& sdp, const std::string& type,
       webrtc::SdpParseError* error);
 
+  // Report to UMA whether an IceConnectionState has occurred. It only records
+  // the first occurrence of a given state.
+  void ReportICEState(
+      webrtc::PeerConnectionInterface::IceConnectionState new_state);
+
+  // Reset UMA related members to the initial state. This is invoked at the
+  // constructor as well as after Ice Restart.
+  void ResetUMAStats();
+
   // Virtual to allow mocks to override.
   virtual scoped_refptr<base::SingleThreadTaskRunner> signaling_thread() const;
 
@@ -246,6 +255,10 @@ class CONTENT_EXPORT RTCPeerConnectionHandler
   RemoteStreamMap remote_streams_;
   scoped_refptr<webrtc::UMAObserver> uma_observer_;
   base::TimeTicks ice_connection_checking_start_;
+
+  // Track which ICE Connection state that this PeerConnection has gone through.
+  bool ice_state_seen_[webrtc::PeerConnectionInterface::kIceConnectionMax];

[tommi (sloooow) - chröme, 2015/08/19 19:29:26]

What about initializing here:

bool ice_state_seen_[webrtc::PeerConnectionInterface::kIceConnectionMax] = {};

[guoweis_left_chromium, 2015/08/19 19:37:29]

Done. 

However, what is the best practice here? Should we start to use c+11
initialization even if anything else is not using that?

[tommi (sloooow) - chröme, 2015/08/19 19:46:18]

Hmm... there aren't that many variables that need explicit initialization. Do
you mind moving them to in-class?  Alternatively I can do it after you land this
cl.

+
   base::WeakPtrFactory<RTCPeerConnectionHandler> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RTCPeerConnectionHandler);